Reduce calls to resolveEndpointsAsync #6838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
requested review from
sameerag,
hectormmg,
jo-arroyo,
peterzenz,
Robbie-Microsoft and
konstantin-msft
as code owners
github-actions
bot
added
msal-browser
konstantin-msft
approved these changes
Jan 23, 2024
lib/msal-browser/src/interaction_client/BaseInteractionClient.ts
Outdated
Show resolved
Hide resolved
hectormmg
approved these changes
Jan 25, 2024
lib/msal-browser/test/interaction_client/BaseInteractionClient.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are building an
Authorityobject and parsing/validating endpoint metadata at least twice in a single request - once to validate it matches the account object passed in and again to build the final request object. This PR refactors to do both these steps at the same time using a singleAuthorityobject. Additionally, telemetry is added to track the number of times an API is invoked over the course of a request to identify redundancies easier.