onRedirectNavigate deprecation fix #7251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jo-arroyo
requested review from
sameerag,
tnorling,
hectormmg,
peterzenz and
konstantin-msft
as code owners
konstantin-msft
approved these changes
Aug 13, 2024
peterzenz
approved these changes
Aug 13, 2024
sameerag
approved these changes
Aug 13, 2024
This is marked as deprecated in the RedirectRequest and if users do set onRedirectNavigate on the RedirectRequest they will get a warning about the field being deprecated and the request not being cached. Let me know if you think we need something further. |
tnorling
approved these changes
Aug 13, 2024
github-actions
bot
added
the
samples
github-actions
bot
removed
the
samples
jo-arroyo
commented
Aug 13, 2024
| @@ -2740,7 +2747,7 @@ describe("RedirectClient", () => { | |||
| await redirectClient.acquireToken(emptyRequest); | |||
| } catch (e) { | |||
| // Test that error was cached for telemetry purposes and then thrown | |||
| expect(window.sessionStorage).toHaveLength(2); | |||
| expect(window.sessionStorage).toHaveLength(1); | |||
There was a problem hiding this comment.
This (and line 3335 below) are reverting a change that was wrongly made in the redirect retry PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two fixes: