-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed UX selectors to id and name for e2e tests #7260
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
samples
Related to the samples apps for the library.
label
Aug 16, 2024
lalimasharda
requested review from
tnorling,
sameerag,
jo-arroyo,
hectormmg,
peterzenz,
bgavrilMS,
Robbie-Microsoft and
konstantin-msft
as code owners
August 23, 2024 17:04
peterzenz
approved these changes
Aug 23, 2024
…tion-library-for-js into fix_UX_selectors_e2e_tests
…AD/microsoft-authentication-library-for-js into fix_UX_selectors_e2e_tests
github-actions
bot
added
documentation
Related to documentation.
msal-browser
Related to msal-browser package
labels
Aug 27, 2024
sameerag
approved these changes
Aug 28, 2024
github-actions
bot
removed
documentation
Related to documentation.
msal-browser
Related to msal-browser package
labels
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving all their UX identifiers from id to class names. This PR addresses this change for our e2e tests to identify UX elements by ids as well as class names where applicable.