-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPM validation in each PR #2181
Conversation
7339db0
to
23378ea
Compare
f54b34f
to
71bc558
Compare
azure_pipelines/pr-validation.yml
Outdated
targetType: 'inline' | ||
script: | | ||
sh spm-integration-test.sh "${BRANCH_NAME}" | ||
continueOnError: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be continueOnError: false? How will errors during build with this branch's MSAL swift package be caught and cause the pipeline to fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, thanks for the catch.
continueOnError: true | ||
|
||
- task: Bash@3 | ||
displayName: Cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add condition: always() for this task so that it always runs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, thank you.
azure_pipelines/pr-validation.yml
Outdated
inputs: | ||
targetType: 'inline' | ||
script: | | ||
UUID_LOCAL=$(uuidgen) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We don't need to create a UUID guid if the branch is going to be deleted in the last step anyways. We can create and delete a branch with the same name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Added a few comments. Otherwise, lgtm |
Set Cleanup to happen always, even if there is an error.
71bc558
to
00a5d7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to manually run the pipeline on this branch as a sanity check
Done: https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1320628&view=results |
Proposed changes
This PR adds a new check in the pr-validation.yml. It consists in an integration of the changes of the current branch into the NativeAuth Sample App using a Swift Package.
These are the steps that are done:
Note: I have checked the
build.py
script and I think it's different enough from what we are trying to do here, so I thought it is better to have two separate jobs, even if both scripts build the framework. I'm open to discussion on this.The time it takes the PR-validation hasn't been incremented, as it runs in parallel and this job takes ~6-10 min.
The following tests have been done:
Type of change
Risk