Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case to show that OBO supports SP #481

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add test case to show that OBO supports SP #481

wants to merge 1 commit into from

Conversation

rayluo
Copy link
Collaborator

@rayluo rayluo commented Jun 8, 2022

  • There is no code change to MSAL's implementation in this PR. This means the existing MSAL Python needs no change to support the OBO-for-SP scenario, perhaps since the initial OBO implementation.
  • This PR contains changes to MSAL's test case, to demonstrate that how OBO for SP could work. It is a matter of how the mid-tier app chooses to manage the potentially-more-than-one SP "accounts", which can be an open topic for discussion.
  • Currently, the test certificate is not committed, so, the new test case will not be run in CI. But it was manually run by PR author.

@bgavrilMS
Copy link
Member

We have an E2E in MSAL.NET - please ping the .NET team to discuss about the certificate.

@micwoj92
Copy link
Contributor

This branch has conflicts that must be resolved.

@rayluo
Copy link
Collaborator Author

rayluo commented Nov 18, 2023

This branch has conflicts that must be resolved.

Thanks. We will be informed of this by github when we revisit this PR (possibly while attempting to solve the test cert topic mentioned above).

Meanwhile, assuming your interest on this topic was driven by your trying to find an OBO example for Service Principal, this PR in its current form (i.e., before merging) still worked as-is, and can serve its current purpose of showcasing how to do OBO with SP.

@bgavrilMS
Copy link
Member

@micwoj92 - just to set expectations here. OBO for service principals is currently being experimented on by some internal teams. There is not way for external customers to configure it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants