Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an unofficial doc for mac broker integration #732

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Add an unofficial doc for mac broker integration #732

merged 2 commits into from
Aug 23, 2024

Conversation

fengga
Copy link
Contributor

@fengga fengga commented Aug 14, 2024

No description provided.

@fengga fengga marked this pull request as ready for review August 15, 2024 20:30
@fengga fengga requested a review from a team as a code owner August 15, 2024 20:30
@fengga fengga marked this pull request as draft August 15, 2024 20:31
rayluo
rayluo reviewed Aug 21, 2024
View reviewed changes
tests/broker-test.py Outdated Show resolved Hide resolved
rayluo
rayluo requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that PR #596 has been merged into dev, please resolve the conflicts in the current PR and then we will review again.

@fengga fengga force-pushed the fengga/add-mrt-mac-integration-doc branch from 7937090 to b5bfaf7 Compare August 22, 2024 17:39
@fengga fengga marked this pull request as ready for review August 22, 2024 17:44
@fengga
Copy link
Contributor Author

fengga commented Aug 22, 2024

broker-test.py passed both on Windows and macOS.

@rayluo rayluo merged commit 4afbd8d into dev Aug 23, 2024
12 checks passed
@rayluo rayluo deleted the fengga/add-mrt-mac-integration-doc branch August 23, 2024 15:10
@rayluo rayluo mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oldalton oldalton oldalton left review comments

@rayluo rayluo rayluo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fengga @rayluo @oldalton