ADFS labs were decommissioned since late July 2025 #845
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Aug 18, 2025
|
|
||
| def test_aad_managed_user(self): # Pure cloud | ||
| config = self.get_lab_user(usertype="cloud") | ||
| config["password"] = self.get_lab_user_secret(config["lab_name"]) | ||
| self._test_username_password(**config) | ||
|
|
||
| @unittest.skip(_ADFS_LABS_DECOMMISSIONED) |
There was a problem hiding this comment.
ADFSv2 was not decommissioned
There was a problem hiding this comment.
When running this test case, it will visit the MEX endpoint of the ADFS https://fs.msidlab4.com/adfs/services/trust/mex
That endpoint gives an http 504 error right now. If it is not decommissioned, then we will need to investigate whether it is not configured properly.
bgavrilMS
reviewed
Aug 18, 2025
| @@ -864,6 +866,7 @@ def test_adfs2_fed_user(self): | |||
| config["password"] = self.get_lab_user_secret(config["lab_name"]) | |||
| self._test_username_password(**config) | |||
|
|
|||
| @unittest.skip(_ADFS_LABS_DECOMMISSIONED) | |||
| def test_adfs2019_fed_user(self): | |||
There was a problem hiding this comment.
When running this test case, it will visit the MEX endpoint of the ADFS https://fs.msidlab8.com/adfs/services/trust/mex
That endpoint gives an http 504 error right now. If it is not decommissioned, then we will need to investigate whether it is not configured properly.
bgavrilMS
requested changes
Aug 18, 2025
gladjohn
reviewed
Aug 19, 2025
| @@ -864,6 +866,7 @@ def test_adfs2_fed_user(self): | |||
| config["password"] = self.get_lab_user_secret(config["lab_name"]) | |||
| self._test_username_password(**config) | |||
|
|
|||
| @unittest.skip(_ADFS_LABS_DECOMMISSIONED) | |||
There was a problem hiding this comment.
Suggested change
| @unittest.skip(_ADFS_LABS_DECOMMISSIONED) | |
| @unittest.skip(_ADFS_TESTS) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the relevant e2e test cases