Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to axum 0.8 #53

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

ethanhann
Copy link
Contributor

@masato-hi
Copy link

Maybe the Provider needs a Send.

masato-hi@e922a0d

@ethanhann
Copy link
Contributor Author

@masato-hi Why do you think Send is needed? I ask because the tests pass without it and I don't see any issues.

@masato-hi
Copy link

@ethanhann
MyProvider needs Send because axum's Handler needs Send.
But InjectProvided Generics did not need it.
Forget my comment.

In other words, adding this line will cause an error, but just adding Send to MyProvider solves it.
masato-hi@e922a0d#diff-86b3ddc2eb3140b3300df4d6542a34f809cfe3345bd1a9746cf59eef24f9bbdbR38

@ethanhann
Copy link
Contributor Author

@AzureMarker Does this look ok to merge to you?

@AzureMarker
Copy link
Owner

I see axum 0.8 added the Sync requirement:

breaking: Require Sync for all handlers and services added to Router and MethodRouter (tokio-rs/axum#2473)

https://github.com/tokio-rs/axum/blob/main/axum/CHANGELOG.md#080

@AzureMarker
Copy link
Owner

AzureMarker commented Jan 12, 2025

Thanks for the PR! I'll release the change after merge.

@AzureMarker AzureMarker merged commit 72c5ff0 into AzureMarker:master Jan 12, 2025
2 checks passed
@AzureMarker
Copy link
Owner

shaku_axum 0.6.0 has been released with axum 0.8 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants