Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

Filter an IVerilog warning #17

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Conversation

krame505
Copy link
Contributor

@krame505 krame505 commented Dec 9, 2020

This was causing a test failure for me, as I was getting a warning SFT files are deprecated. Please pass the VPI module instead. from the sysGCD test in this directory, when an empty output was expected. Probably the result of using a newer version of Icarus Verilog?

@quark17
Copy link
Collaborator

quark17 commented Dec 9, 2020

Yes, this is mentioned in issue #16. It'd be best if someone could update BSC to avoid the deprecated invocation of iverilog when the version is 11, but if you don't want to look into that, and just want to filter it here, that's fine. (If someone else wants to identify what the new invocation of iverilog would look like, I can do the updating of the BSC script.)

Is there a reason that you chose to ignore all deprecation warnings (not specifically SFT) and for all iverilog versions? There's already code in the next lines that ignores messages in version 10.1, so we could do something similar and only filter for version 11 and only the SFT message. Do you have an opinion? The fact that the testsuite caught the deprecation warning alerted us both to the fact that BSC needs to be updated but also that the CI environment changed; if we can continue to catch those situations by not doing any filtering here, that'd be nice. (But this is just one place, not the whole suite, and it's testing something orthogonal; so maybe you could make a case to just filter here.)

@krame505
Copy link
Contributor Author

krame505 commented Dec 9, 2020

Thanks for the pointer, I didn't see that issue.

I don't really want to try fixing this in bsc right now, but I agree that being more specific in the filtering here is better - I went ahead and made this change.

@krame505 krame505 mentioned this pull request Dec 13, 2020
@quark17 quark17 merged commit c4501ff into B-Lang-org:master Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants