Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support splitting up struct method parameters into multiple input ports #729

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Support splitting up struct method parameters into multiple input ports #729

wants to merge 44 commits into from

Commits on Aug 1, 2024

  1. Initial, hacky work on computing wrapper interface method types using… 

    … type classes
    @krame505
    krame505 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    49532f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Attempt at attachting port names with a primative on every input. Doe… 

    …sn't work b/c lambda bodies aren't partially evaluated before iExpandMethod.
    @krame505
    krame505 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    363cc7b View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Pass the input port names by tagging methods with a new primative

    @krame505
    krame505 committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    b24ca9c View commit details
    Browse the repository at this point in the history

  2. Refactor WrapMethod type class

    @krame505
    krame505 committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    92fa2e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Input port splitting works end-to-end, modulo sanity checks and savin… 

    …g port types
    @krame505
    krame505 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c6b22fa View commit details
    Browse the repository at this point in the history

  2. Handle prefix for input port names via wrap typeclasses

    @krame505
    krame505 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    57258ec View commit details
    Browse the repository at this point in the history

  3. Saving port types using WrapField type class method

    @krame505
    krame505 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    8fdb09d View commit details
    Browse the repository at this point in the history

  4. Bug fixes

    @krame505
    krame505 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    5945a7c View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Use WrapField to determine noinline foreign function types

    @krame505
    krame505 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    25695a4 View commit details
    Browse the repository at this point in the history

  2. Cleanup, add DeepSplitPorts type class

    @krame505
    krame505 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    6568cc8 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Add primMethod wrapper prim calls in vMkRWire1

    @krame505
    krame505 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    1b1f033 View commit details
    Browse the repository at this point in the history

  2. Update expected test output

    @krame505
    krame505 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    730f044 View commit details
    Browse the repository at this point in the history

  3. Re-add module arg port type saving, still need to do port name confli… 

    …ct checking
    @krame505
    krame505 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7975da7 View commit details
    Browse the repository at this point in the history

  4. Fix saving Inout port types

    @krame505
    krame505 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    3ba06d4 View commit details
    Browse the repository at this point in the history

  5. Update test expected output

    @krame505
    krame505 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    96c35e5 View commit details
    Browse the repository at this point in the history

  6. Update expected test output

    @krame505
    krame505 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d08c97a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Fix prefix computation in genwrap 'to' function and port saving state… 

    …ment construction
    @krame505
    krame505 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    b651d36 View commit details
    Browse the repository at this point in the history

  2. Fix inadvertantly disabled type check for foreign functions

    @krame505
    krame505 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    4020ade View commit details
    Browse the repository at this point in the history

  3. Update test expected results

    @krame505
    krame505 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2c9e86e View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Add interface port name sanity checking after elaboration

    @krame505
    krame505 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    0c15378 View commit details
    Browse the repository at this point in the history

  2. Fix bug introduced in computing split vector interface prefixes

    @krame505
    krame505 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    1ecce93 View commit details
    Browse the repository at this point in the history

  3. Add sketch of splitting tuples

    @krame505
    krame505 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    936d140 View commit details
    Browse the repository at this point in the history

  4. Check for clash with default clock/reset ports

    @krame505
    krame505 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    eccaf03 View commit details
    Browse the repository at this point in the history

  5. Better error message for synthesizing an interface with a non-Bits me… 

    …thod
    @krame505
    krame505 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    4e48c17 View commit details
    Browse the repository at this point in the history

  6. Cleanup trailing whitespace

    @krame505
    krame505 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    14fb02c View commit details
    Browse the repository at this point in the history

  7. Update expected results, testsuite passing

    @krame505
    krame505 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    7aea56f View commit details
    Browse the repository at this point in the history

  8. Reorganize port splitting utilites into a seperate library, add Shall… 

    …owSplitPorts
    @krame505
    krame505 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    af1e1eb View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. More efficient implementation of splitting vectors

    @krame505
    krame505 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a52f2e6 View commit details
    Browse the repository at this point in the history

  2. Avoid extra _1 suffix for DeepSplitPorts on Int/UInt

    @krame505
    krame505 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    36a4dc2 View commit details
    Browse the repository at this point in the history

  3. Add test cases for port splitting

    @krame505
    krame505 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8999a65 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Add test of DeepSplitPorts with an explicit non-recursive instance

    @krame505
    krame505 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    be3d910 View commit details
    Browse the repository at this point in the history

  2. Fix NoSplit instance

    @krame505
    krame505 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    150d29c View commit details
    Browse the repository at this point in the history

  3. Add a comment

    @krame505
    krame505 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c8114b1 View commit details
    Browse the repository at this point in the history

  4. Stuff the field name in the WrapField type class as a type parameter … 

    …for better error messages.
    @krame505
    krame505 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0ea992e View commit details
    Browse the repository at this point in the history

  5. Fix trailing whitespace

    @krame505
    krame505 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9d7921f View commit details
    Browse the repository at this point in the history

  6. Addressing Ravi's comments

    @krame505
    krame505 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f0d8ac7 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Fix more comments

    @krame505
    krame505 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7067fbe View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Fix testsuite failure after error message tweak

    @krame505
    krame505 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0e23ad0 View commit details
    Browse the repository at this point in the history

  2. Record the full field name path in WrapField context, for better erro… 

    …rs for a non-synthesizable subinterface
    @krame505
    krame505 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1329534 View commit details
    Browse the repository at this point in the history

  3. Don't surface implicit conditions from inside ICMethod

    @krame505
    krame505 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6f8c504 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. FIx trailing whitespace

    @krame505
    krame505 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b1165c9 View commit details
    Browse the repository at this point in the history

  2. Slightly less gross list deconstruction in IExpand

    @krame505
    krame505 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    0868d79 View commit details
    Browse the repository at this point in the history

  3. Add more tests

    @krame505
    krame505 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    df0f863 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into genwrap

    @krame505
    krame505 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d7b1859 View commit details
    Browse the repository at this point in the history