Add unit tests for rotations between frames #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moeyensj
force-pushed
the
jm/rotation-tests
branch
2 times, most recently
from
710f913
to
c57ef5b
Compare
moeyensj
force-pushed
the
jm/rotation-tests
branch
2 times, most recently
from
2e785a1
to
93ed3ce
Compare
…ecliptic reference frame
…igin) and rotations (via cartesian_to_frame)
…ansform_coordinates
moeyensj
force-pushed
the
jm/rotation-tests
branch
from
93ed3ce
to
0bdb11c
Compare
This was referenced Aug 25, 2023
spenczar
approved these changes
Aug 28, 2023
| "elements_sun.csv" | ||
| "elements_sun_ec.csv" | ||
| ) | ||
| df = pd.read_csv( |
There was a problem hiding this comment.
could do an inline table here. don't need to though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..and fixes a pretty serious bug in the rotation function.