Add method for setting a column's value #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The doc build failure is due to pradyunsg/furo#693, and is spurious; it should be fixed once readthedocs is using Sphinx 7.2.2. |
moeyensj
reviewed
Aug 18, 2023
There was a problem hiding this comment.
I've tested this with some adam_core examples and it works! This really makes it a lot clearer that we get a modified copy back.
What do you think about setting nullable columns to None? Table.set_column("name", None)? If I try an operation like that I get:
TypeError: 'NoneType' object is not iterableThis was previously possible through direct access, but this is a lot clearer and cleaner. It makes it much more obvious that this happens as a copy, not in-place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously possible through direct access, but this is a lot clearer and cleaner. It makes it much more obvious that this happens as a copy, not in-place.
TODO:
Column.__set__is implemented, possibly discarding it entirely