Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic docker deployment with Github Actions #25

Closed
wants to merge 1 commit into from

Conversation

rk1a
Copy link
Contributor

@rk1a rk1a commented Aug 31, 2022

This addresses #13.
In order for the workflow to go through we need to set up the following secrets in the repository settings:
DOCKERHUB_USERNAME: rk1a
DOCKERHUB_TOKEN: dckr_pat_1rWO2yOF3YQ5BeoZtsUKQfACye4
(we can of course also use a different docker hub account)

I think setting up secrets can only be done by the owner @lauritowal

@rk1a rk1a requested a review from lauritowal August 31, 2022 13:24
@rk1a rk1a self-assigned this Aug 31, 2022
@lauritowal
Copy link
Contributor

lauritowal commented Aug 31, 2022

I'll have a look.

@rk1a the image would not be available for the public audience, right? Also is it free to build images via GitHub and upload them to docker hub? Did you try it on another repo?
Could you also please update the project's Readme: What needs to be done after changes to the Image / Dockerfile to start the deployment process? Is pushing to the repo enough? Please describe it a bit there

@rk1a
Copy link
Contributor Author

rk1a commented Sep 13, 2022

  • I tried in another repo and it worked there
  • But the image would be public on Dockerhub, so I am not sure if that works for us.
  • Building and uploading to Dockerhub is free.
  • The build is triggered on pushing to the main branch, but probably would be enough if one of the dependency files/Dockerfile itself changes

@rk1a
Copy link
Contributor Author

rk1a commented Oct 16, 2022

This is not needed anymore.

@rk1a rk1a closed this Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants