Add more attributes to output DTOs for negotiator resources #598
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
============================================
- Coverage 84.63% 84.61% -0.02%
Complexity 1011 1011
============================================
Files 150 150
Lines 3795 3797 +2
Branches 237 237
============================================
+ Hits 3212 3213 +1
- Misses 414 415 +1
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -43,4 +43,7 @@ public class OrganizationDTO { | |||
|
|
|||
| @Schema(description = "URI of the organization", example = "https://organization.org") | |||
| private String uri; | |||
|
|
|||
| @Schema(description = "Indicates if the organization is withdrawn", example = "false") | |||
There was a problem hiding this comment.
What does withdrawn mean? :)
There was a problem hiding this comment.
Changed to "revoked" in 4ec4c46
There was a problem hiding this comment.
what does revoked mean? :)
backend/src/main/java/eu/bbmri_eric/negotiator/governance/resource/ResourceModelMapper.java
Outdated
Show resolved
Hide resolved
| @Nullable private String description; | ||
|
|
||
| @Nullable private String contactEmail; | ||
|
|
||
| @Nullable private String uri; | ||
|
|
There was a problem hiding this comment.
again this DTO is deprecated. The ResourceResponseModel and ResourceWithStatusDTO are used
There was a problem hiding this comment.
The problem here is that it has been deprecated, but several tests, changed in this PR, still use this class. Should we change again the tests and definitely remove this class ? Same in the code, for example ResourceModelMapper is still using it.
There was a problem hiding this comment.
do not remove the class for now, its fine that some tests use it
asulis
force-pushed
the
feat/add_sync_attrs_to_dto
branch
from
754b961 to
668da0c
Compare
… tests accordingly
asulis
force-pushed
the
feat/add_sync_attrs_to_dto
branch
from
3876d0f to
ddcaa08
Compare
Negotiator pull request:
Description:
Not all attributes for Organizations, resources and Network are currently provided in the DTOs output objects (and so they are not available in the Frontend). This PR adds these attributes to the DTOs objects.
Checklist:
Make sure you tick all the boxes below if they are true or do not apply before you ask for review