Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move REPRESENTATIVE_UNREACHABLE to not Represented Organization… #619

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmilost
Copy link
Collaborator

@tmilost tmilost commented Jan 27, 2025

Brief description.
hey Cecilia, so the horizontal line divides those that you represent

Those at the top are yours so to speak

or rather thats how it should work

but now I'm seeing that there could be a bug in this display

yes the ones that are unreachable are displayed at the top as well which should not happen, thanks for flagging this

Desired functionality acceptance criteria
move organization with status REPRESENTATIVE_UNREACHABLE to notRepresentedOrganizationsById

@tmilost tmilost requested a review from RadovanTomik January 27, 2025 16:22
@tmilost tmilost self-assigned this Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.63%. Comparing base (628c269) to head (2c591c9).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #619   +/-   ##
=========================================
  Coverage     84.63%   84.63%           
  Complexity     1011     1011           
=========================================
  Files           150      150           
  Lines          3795     3795           
  Branches        237      237           
=========================================
  Hits           3212     3212           
  Misses          414      414           
  Partials        169      169           
Flag Coverage Δ
unit 84.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] REPRESENTATIVE_UNREACHABLE is displayed in representedOrganizationsById
1 participant