Added an Ophyd-async device to match the threaded Ophyd device. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an Ophyd-async device that can connect to the apsbss IOC. Also adds a few dependencies to support Ophyd-async, namely
ophyd-async,aioca, andpytest-asyncio.One major difference, besides needing to await the various methods, is that the users for the proposal and ESAF use ophyd-async's device vector.
Threaded-ophyd:
Ophyd-async:
Doesn't have to be that way, so if backward compatibility is crucial, it can be re-written to match the threaded implementation. Could also be 1-indexed if desired.
This device also includes the
_table()method, but instead of PVname, it uses ophyd-async'ssourceattribute, so PV names will be shown as "ca://ioc:bss:..." (extra "ca://" prefix). This also works for non-CA signals, but I don't think there are any here (e.g. "pva://ioc:bss:...").