Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Add support for NumPy 2.0 #362

Merged
merged 5 commits into from
Jul 4, 2024
Merged

REFACTOR: Add support for NumPy 2.0 #362

merged 5 commits into from
Jul 4, 2024

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Nov 8, 2023

Connected to BCG-X-Official/facet#376.

@j-ittner j-ittner changed the title REFACTOR: Adhere to NumPy 2.0 changes REFACTOR: Add support for NumPy 2.0 Nov 14, 2023
@j-ittner j-ittner changed the base branch from 2.1.x to 3.0.x July 4, 2024 17:09
@j-ittner j-ittner added the build label Jul 4, 2024
@j-ittner j-ittner self-requested a review July 4, 2024 17:10
@mtsokol
Copy link
Contributor Author

mtsokol commented Jul 4, 2024

@j-ittner I think that all Facet / skleandf / pytools dependencies already have 2.0 compatible release. Here's a tracking list for downstream (it says which version introduces compatibility): numpy/numpy#26191 (comment).
I think only SHAP isn't listed but they already added it shap/shap#3712.

I think we can merge NumPy 2.0 PRs here.

@mtsokol
Copy link
Contributor Author

mtsokol commented Jul 4, 2024

Looks like SHAP 0.46.0 is the compatible version: https://github.com/shap/shap/releases/tag/v0.46.0

@j-ittner
Copy link
Member

j-ittner commented Jul 4, 2024

Looks like SHAP 0.46.0 is the compatible version: https://github.com/shap/shap/releases/tag/v0.46.0

Many thanks @mtsokol , very helpful!

@j-ittner j-ittner merged commit 3fd8072 into 3.0.x Jul 4, 2024
13 checks passed
@j-ittner j-ittner deleted the numpy-2-0-compat branch July 4, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants