Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
강제 업데이트 네비게이션 생성 #61
강제 업데이트 네비게이션 생성 #61
Changes from 14 commits
ee834b9
fd7b985
4d476d1
69c143c
3ee866b
141eb19
471b525
124a177
4992e3b
b8b1388
2d36b71
c76ce49
350810c
d069494
520e6e3
8e8c4f9
97fca54
c54da2b
fa95ccd
a5c1238
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 페이지도 하나의 Form이고, 각각의 요소가 상태이므로 다른 페이지처럼 바꿔서 쓰는게 디자인적 통일 & 시간적 이득을 볼 수 있었을 것 같아요.
<CustomForm.Input />
으로 구조화하는건 어려웠을까요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
말씀해주신 부분을 반영해서 전체적으로
CustomForm
을 사용하여 구조를 변경했습니다!다만, 주요 변경 사항이 있습니다!
content
의 길이가 한 줄 이상으로 길어지는 경우CustomForm.Input
을 사용하면 antd의 Input 특성 때문에? 한 줄로만 보여줘서 모든 text를 보여주지 못 하더라고요. 따라서CustomForm.TextArea
를 사용하고자 했습니다.기존
CustomForm
에CustomTextArea
에서는 글자 수를 보여주는showCount
와 행 수에 따른size
를 자동으로 조절해주는autoSize
속성이 없어 추가했습니다. style 속성도 변경하고 싶어 아래와 같이 추가했습니다..!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.