-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 어드민 히스토리 기능 수정 #1087
base: develop
Are you sure you want to change the base?
fix: 어드민 히스토리 기능 수정 #1087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기서는 딱히 변경 할게 보이지는 않는 것 같네요 고생하셨습니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고 많으셨습니다!
public AdminActivityHistory( | ||
Integer domainId, HttpMethodType requestMethod, | ||
DomainType domainName, String requestMessage, Admin admin | ||
) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C
이 부분 현수형이 리뷰해준대로 필드 하나씩 줄바꿈하는거 어떨까요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵
(:#{#condition.requestMethod?.name()} IS NULL OR a.requestMethod = :#{#condition.requestMethod}) AND | ||
(:#{#condition.domainName?.name()} IS NULL OR a.domainName = :#{#condition.domainName}) AND |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A
왼쪽은 ?.name()을 추가했는데, 오른쪽은 추가안한 이유가 먼가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domainName과 requestMethod가 null인 경우를 체크하기 위해 ?
을 붙여줬습니다. 그렇지 않으면 NPE가 터져버립니다.
오른쪽이 null이면 문장이 true이기 때문에 오른쪽 조건을 검사하지 않습니다.
만약, 왼쪽이 null이 아닌 경우 (즉 false)인 경우는 오른쪽 조건을 검사하기 때문에 ?을 붙이지 않고 값을 그대로 가져갑니다.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항