fix: 어드민 히스토리 기능 수정 #1087
Open
fix: 어드민 히스토리 기능 수정 #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soundbar91
requested review from
seongjae6751,
daheeParkk,
kwoo28 and
duehee
seongjae6751
approved these changes
Nov 30, 2024
kwoo28
approved these changes
Nov 30, 2024
Comment on lines
55
to
58
| public AdminActivityHistory( | ||
| Integer domainId, HttpMethodType requestMethod, | ||
| DomainType domainName, String requestMessage, Admin admin | ||
| ) { |
There was a problem hiding this comment.
C
이 부분 현수형이 리뷰해준대로 필드 하나씩 줄바꿈하는거 어떨까요
Comment on lines
+30
to
+31
| (:#{#condition.requestMethod?.name()} IS NULL OR a.requestMethod = :#{#condition.requestMethod}) AND | ||
| (:#{#condition.domainName?.name()} IS NULL OR a.domainName = :#{#condition.domainName}) AND |
There was a problem hiding this comment.
A
왼쪽은 ?.name()을 추가했는데, 오른쪽은 추가안한 이유가 먼가요??
There was a problem hiding this comment.
domainName과 requestMethod가 null인 경우를 체크하기 위해 ?을 붙여줬습니다. 그렇지 않으면 NPE가 터져버립니다.
오른쪽이 null이면 문장이 true이기 때문에 오른쪽 조건을 검사하지 않습니다.
만약, 왼쪽이 null이 아닌 경우 (즉 false)인 경우는 오른쪽 조건을 검사하기 때문에 ?을 붙이지 않고 값을 그대로 가져갑니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항