Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#46_CICD_DB_Docker_고도화 #58

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

02ggang9
Copy link
Collaborator

@02ggang9 02ggang9 commented Jan 28, 2024

#️⃣ 연관된 이슈

#46

📝 작업 내용

Docker DB Image를 캐싱하도록 합니다. 만약 caching miss가 일어난다면 ECR에 있는 이미지를 가져오도록 합니다.

💬 리뷰 요구사항(선택)

리뷰를 반영해 RP 이름을 수정했고 기존의 PR은 close 했습니다!

⏰ 예상했던 소요시간/실제 소요시간(선택)

@02ggang9 02ggang9 added 🐳 인프라 인프라와 관련된 문제 및 작업 😑 P2 우선순위 낮음 👍 개선 기존 기능 개선 또는 사용성 향상과 같은 최적화 작업 labels Jan 28, 2024
@02ggang9 02ggang9 self-assigned this Jan 28, 2024
Copy link
Collaborator

@amaran-th amaran-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~! 수고하셨어요!

Copy link
Contributor

@shkisme shkisme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당~

- name: Pull DB Image From ECR
if: steps.db-docker-image.outputs.cache-hit != 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이렇게 캐시 히트 발생 여부를 확인할 수 있군요~ 알아갑니다.

Comment on lines -31 to -34
tasks.named('test') {
useJUnitPlatform()
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@JJimini JJimini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 수고하셨습니다~!

@02ggang9 02ggang9 merged commit f182695 into develop Feb 2, 2024
1 check failed
@02ggang9 02ggang9 deleted the Feature/#46_CICD_DB_Docker_고도화 branch February 2, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐳 인프라 인프라와 관련된 문제 및 작업 👍 개선 기존 기능 개선 또는 사용성 향상과 같은 최적화 작업 😑 P2 우선순위 낮음
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants