Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log Av grid spacing option #823

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

karllark
Copy link
Member

@karllark karllark commented Sep 30, 2024

Log A(V) spacing enabled. This is picked by add adding a "log" as the 4th element of the vector defining the A(V) grid. E.g., [0.01, 10.0, 0.1, "log"] to get a logAv spacing of 0.1 between 0.01 and 10.0.

This required adding in grid weights for all the dust parameters. Previously, these were always the same given a linear grid was used implicitly.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 8 lines in your changes missing coverage. Please review.

Project coverage is 41.98%. Comparing base (487f14a) to head (8754af2).

Files with missing lines Patch % Lines
beast/physicsmodel/model_grid.py 37.50% 5 Missing ⚠️
beast/tools/verify_beast_settings.py 75.00% 2 Missing ⚠️
beast/physicsmodel/grid_and_prior_weights.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
+ Coverage   41.97%   41.98%   +0.01%     
==========================================
  Files         108      108              
  Lines       10288    10302      +14     
==========================================
+ Hits         4318     4325       +7     
- Misses       5970     5977       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karllark karllark changed the title adding log Av grid spacing - explicit dust parameter grid weights now Add log Av grid spacing option Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant