Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary exploration of what documentation is required #389

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brinxmat
Copy link
Contributor

Here, I'm attempting to add documentation for the top-level and add a lower-level "main" doc, I think it is useful at the top level to link to the main docs for each module. I think it is at the top level that we should say generally what things do and which. to choose if there is a choice (e.g. apigw v1 or v2). I wonder if adding the install information here is also useful for quick reference? Maybe overkill.

In the main docs, I try to provide examples, but some of the docs will become huge and a bit unhelpful since, e.g., RequestInfo is a POJO with many methods, and here I think it is more helpful to document what the methods do and what they return…not sure I did an amazing job here, but it is a start.

I recognize that I struggle to explain a few things and have added notes for the reviewer, these should be removed in the final version by a valid explanation. Maybe I should be more descriptive in general too?

I also see we have a number of visibility issues, I have remarked on these and we should have a discussion before we move forward.

@brinxmat brinxmat requested a review from axthosarouris August 28, 2022 11:36
#### Install

```groovy
runtimeOnly group: 'com.github.bibsysdev', name: 'apigateway', version: '$version'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually we need more that runtimeOnly because we extend the ApiGatewayHandler and we use the ApiGateway Exceptions

@brinxmat brinxmat requested a review from axthosarouris August 30, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants