adding addition methods to identity service client #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brinxmat
requested changes
Jan 27, 2025
| @@ -2,11 +2,17 @@ | |||
|
|
|||
| import com.fasterxml.jackson.annotation.JsonProperty; | |||
| import java.net.URI; | |||
| import java.util.List; | |||
| import java.util.UUID; | |||
| import no.unit.nva.commons.json.JsonSerializable; | |||
|
|
|||
| public record GetCustomerResponse(@JsonProperty("id") URI id, UUID identifier, String name, String displayName, | |||
There was a problem hiding this comment.
Can we rename this class? "GetCustomerResponse" has unfortunate connotations. CustomerDto or Customer?
| .uri(customerId); | ||
| return attempt(getHttpResponseCallable(request)) | ||
| .map(this::validateResponse) | ||
| .map(r -> mapResponse(GetCustomerResponse.class, r)) |
Comment on lines
+100
to
+102
| var request = HttpRequest.newBuilder() | ||
| .GET() | ||
| .uri(customerId); |
There was a problem hiding this comment.
This can be extracted, and add relevant headers (e.g. Accept, possibly Accept-Encoding) since there are some defaults that Java inserts (actually, check these by adding a breakpoint and get back to me)
Comment on lines
+110
to
+112
| var request = HttpRequest.newBuilder() | ||
| .GET() | ||
| .uri(constructListCustomerUri()); |
Comment on lines
+224
to
+227
| var request = HttpRequest.newBuilder() | ||
| .GET() | ||
| .uri(customerId) | ||
| .build(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding methods for fetching customer by id and listing all customers to IdentityServiceClient, so there is noe need to implement "complex configured" http client each time we need to make authenticated request to identity-service.