Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positives, fixed by nestedQuery #604

Merged
merged 1 commit into from
Oct 18, 2024
Merged

False positives, fixed by nestedQuery #604

merged 1 commit into from
Oct 18, 2024

Conversation

StigNorland
Copy link
Contributor

No description provided.

@StigNorland StigNorland self-assigned this Oct 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

Test Results

 30 files  ±0   30 suites  ±0   47s ⏱️ -3s
867 tests ±0  864 ✅ ±0  3 💤 ±0  0 ❌ ±0 
900 runs  ±0  897 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit c7b38ea. ± Comparison against base commit 5a6b331.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both. 
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=i1S1JX9T6CGrU, documentIdentifier=null], resource={"ctpOeku638aUDY2":{"ODUWOWSYFrQFKhJeI":"KM8aI8N2xb9GtPGS0","PqF98SGuMDhCG72VGJx":"MNaUMxVpPv6xVjg3z","sy49rAG1xnOEA3QP":"is3yneffWBh","ljvBSJ7FOtHcqR":"aDf8hlg0eqCFcOE","XCK3jgXlJ7NB6DG7":"6JyV61zumAHofu"},"CIbLsbnKrjGpN9YelU":{"BuY0edAvXeWzd":"RWCAv7XXKq","3d61AmuIVY8vO4jq0I":"lNcenJ4UfC","BG97gLYGRwo":"YinIDS41zc1","f9q1aZHCR3EU8Sq":"lNFbIby7lwY","knS6pSsLVgxcHL":"J6yOQQe9ElJmMs"},"CKXZ…
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=null, documentIdentifier=01929a55fbcb-95370383-9d62-4ad5-905d-760b002e45ee], resource={"o3TjjZublcYxB3rsI":{"eFYjOkHEUhU":"Sm836FfRFKGCnvPEQ","i06xLUWnubIy49t":"px74TqahMPBVVs8Tr4","xdO6b5p79yN3IU22RRV":"y8ynBfkKh0OO0","6MdwEPHlg06":"4l2xJJgrl6Gw5jpoUdR","elCaYiFxwItwerW4":"0YnHKLZfGMUA"},"PSFR1GcIke":{"5TsCXJrgxmcf":"MHVyEIlmEbXcNC","F2XKsUuV1dNPY6B":"cyHmpGtnbmig","rR8MzhFNqjGNNL4aVUL":"FD8YRr9y7c7","xnJp5mX2aq3lZP9MM0":"ugqtkAkWWh2LjRr…
no.unit.nva.search.resource.ResourceClientTest ‑ [216] https://x.org/?size=22&UNIDENTIFIED_NORWEGIAN=true, 4

no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=frCBrYbCtXU3t6zlvV, documentIdentifier=null], resource={"yaKLmVKxrNAQJ":{"mW3cEl8pjiZq":"qzhIFvhUWvQ4Cx","aSOHYhbVKANcAo":"6oT9WpxeWHGZGQ8WS","1VTinTt07q7u":"mkbg2uEdMl","a47rnVlujBoxsGilP7":"AE4isD2XAko0A3kam","w7gWtM89EFfL5ZfD5KY":"LSGBlPmSEYPZQu08S"},"iSNPUN0byrHnW":{"7G3Gprj1naq":"TZlu3IBG6cXpSEjv","iiCbsklQJ9V1aethxk":"bhEFfEZTu3tX","VO4Ld4RlEJ":"N4GpjX6w03uGMsvq","lMpgH7k6cNb":"wxPqV0LtVjeppWx","rFb6wvRNxUdGxX":"0xNwsEncfHOTplnbDU"}…
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=null, documentIdentifier=01929ed37699-58bf24f6-0df2-4beb-93b3-4dc595663c73], resource={"x3UFD8NiCUu":{"5ObpRqnp4fRCYzHH":"NFc9jYxl6fPp1u7PtM","QFHFgs1u2tf":"7FOg5Vdv29kipJCAXR","euW2kRF2igCT3DGcwN":"YN8DsRrzPQmi9v","7t6TkhqGaCbOm5lm5kM":"lXe0hmVTrBMgS","pvtQnGzJBCUTNU":"t6PJvXHqH5KLn5ow6e0"},"pnv6eRay0G7azE":{"hVHPMta2zh3Yn":"BEcwLWxAPJO5KjCrEm0","QM0luOQY1yBTABw":"zreuSD5CnsEU","BVzdpOtzVVkj0":"3btIbB6HnyHdnu74U1","5TCyc7VWF8U9YXE3zED":"…
no.unit.nva.search.resource.ResourceClientTest ‑ [216] https://x.org/?size=22&UNIDENTIFIED_NORWEGIAN=true, 2

♻️ This comment has been updated with latest results.

StigNorland
StigNorland commented Oct 18, 2024
View reviewed changes
search-commons/src/main/java/no/unit/nva/search/resource/ResourceStreamBuilders.java
Comment on lines +135 to +136
nestedQuery(
ENTITY_CONTRIBUTORS,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual code change....

StigNorland
StigNorland commented Oct 18, 2024
View reviewed changes
search-commons/src/main/java/no/unit/nva/search/resource/Constants.java
Copy link
Contributor Author

@StigNorland StigNorland Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied jsonPath to all constants (besides that, no code changes)

StigNorland
StigNorland commented Oct 18, 2024
View reviewed changes
search-commons/src/test/resources/resource_urls.json
"UNIDENTIFIED_NORWEGIAN=true": 4,
"UNIDENTIFIED_NORWEGIAN=true": 2,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eqaul no false positives

truhacevkir
truhacevkir reviewed Oct 18, 2024
View reviewed changes
search-commons/src/main/java/no/unit/nva/search/resource/Constants.java

public static final String CONTRIBUTOR_ORG_KEYWORD =
jsonPath(CONTRIBUTOR_ORGANIZATIONS, KEYWORD);

public static final String CONTRIBUTORS_AFFILIATION_ID_KEYWORD =
ENTITY_CONTRIBUTORS_DOT + AFFILIATIONS + DOT + ID + DOT + KEYWORD;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@StigNorland StigNorland merged commit 800c2dc into main Oct 18, 2024
5 checks passed
@StigNorland StigNorland deleted the hotfix/Unverified-norwegian branch October 18, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truhacevkir truhacevkir truhacevkir approved these changes

Assignees

@StigNorland StigNorland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StigNorland @truhacevkir