Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Python, wrap all input strings in double quotes. #5758

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

dpgrote
Copy link
Member

@dpgrote dpgrote commented Mar 11, 2025

This avoids problems when there are spaces in the expressions.

@ax3l ax3l added the component: Python Python layer label Mar 11, 2025
@ax3l ax3l requested review from ax3l and WeiqunZhang March 11, 2025 21:45
@EZoni
Copy link
Member

EZoni commented Mar 13, 2025

Note that our CI tests in the Azure DevOps pipelines did not run for this PR, neither in https://dev.azure.com/BLAST-WarpX/WarpX/_build?definitionId=1 nor in https://dev.azure.com/ECP-WarpX/WarpX/_build?definitionId=3.*

You could retrigger CI now (e.g., git commit --amend, then git push -f) and I expect that the CI tests should run in at least one of the two pipelines.

*We are working on resolving the redundancy in the pipelines and any related issues.

@EZoni
Copy link
Member

EZoni commented Mar 13, 2025

I think Azure was still broken at the time of the last (merge) commit here. Now it should be fixed. I think we need to retrigger the CI checks one more time.

@dpgrote dpgrote closed this Mar 14, 2025
@dpgrote dpgrote reopened this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Python Python layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants