Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add automated test for ion impact ionization #5761

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

RemiLehe
Copy link
Member

TODO: update analysis script and recreate checksums

@EZoni
Copy link
Member

EZoni commented Mar 12, 2025

Just a side comment, as far as creating the checksum file is concerned, I think this could be a good opportunity to verify that the steps in our how-to documentation (https://warpx.readthedocs.io/en/latest/developers/how_to_test.html#how-to-add-automated-tests) work properly, in particular step 7. below (I'm not sure if developers actually do this, instead of copying existing checksums and then overwriting them):

Screenshot from 2025-03-12 10-04-18

@roelof-groenewald roelof-groenewald marked this pull request as ready for review March 13, 2025 05:40
@roelof-groenewald
Copy link
Member

@EZoni I was able to reset the benchmarks using the instructions you linked 🎉 .
I guess we'll see if the checksum values from my local system matches what the Azure systems get.

@RemiLehe I modified the scattering logic to avoid the nan values from before (at least for the test you created). Could you please check if the update works for your actual use case?

Btw, I checked that the electron impact ionization test still match theory (as close as it did before), and it looks good:
ionization_dsmc_density_Te

@roelof-groenewald
Copy link
Member

TODO: update analysis script and recreate checksums

@RemiLehe are you planning on updating the analysis script to get the theoretical ion impact ionization rate and the effect on the ion temperature?

@roelof-groenewald roelof-groenewald added bug Something isn't working component: collisions Anything related to particle collisions labels Mar 13, 2025
@@ -21,7 +22,7 @@ warpx.const_dt = 1e-09
geometry.dims = 3
geometry.prob_hi = 0.1 0.1 0.1
geometry.prob_lo = 0 0 0
amr.max_grid_size = 8
amr.max_grid_size = 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the test runs on 2 procs but with max_grid_size=8 there was only 1 tile, so parallel execution was not really tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: collisions Anything related to particle collisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants