-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add automated test for ion impact ionization #5761
base: development
Are you sure you want to change the base?
Conversation
Just a side comment, as far as creating the checksum file is concerned, I think this could be a good opportunity to verify that the steps in our how-to documentation (https://warpx.readthedocs.io/en/latest/developers/how_to_test.html#how-to-add-automated-tests) work properly, in particular step 7. below (I'm not sure if developers actually do this, instead of copying existing checksums and then overwriting them): |
Signed-off-by: roelof-groenewald <[email protected]>
@EZoni I was able to reset the benchmarks using the instructions you linked 🎉 . @RemiLehe I modified the scattering logic to avoid the Btw, I checked that the electron impact ionization test still match theory (as close as it did before), and it looks good: |
@RemiLehe are you planning on updating the analysis script to get the theoretical ion impact ionization rate and the effect on the ion temperature? |
@@ -21,7 +22,7 @@ warpx.const_dt = 1e-09 | |||
geometry.dims = 3 | |||
geometry.prob_hi = 0.1 0.1 0.1 | |||
geometry.prob_lo = 0 0 0 | |||
amr.max_grid_size = 8 | |||
amr.max_grid_size = 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the test runs on 2 procs but with max_grid_size=8
there was only 1 tile, so parallel execution was not really tested.
TODO: update analysis script and recreate checksums