web: fix PHP warning in login action.

Apparently urldecode(null) gets a warning in current PHP
BOINC · Dec 4, 2023 · 7aeb4e7 · 7aeb4e7
1 parent b978d5c
commit 7aeb4e7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/html/user/login_action.php b/html/user/login_action.php
@@ -160,9 +160,11 @@ function login_with_ldap($uid, $passwd, $next_url, $perm) {
 }
 
 $next_url = post_str("next_url", true);
-$next_url = urldecode($next_url);
-$next_url = sanitize_local_url($next_url);
-if (strlen($next_url) == 0) {
+if ($next_url) {
+    $next_url = urldecode($next_url);
+    $next_url = sanitize_local_url($next_url);
+}
+if (!$next_url) {
     $next_url = USER_HOME;
 }
 

diff --git a/sched/file_upload_handler.cpp b/sched/file_upload_handler.cpp
@@ -316,6 +316,9 @@ int handle_file_upload(FILE* in, R_RSA_PUBLIC_KEY& key) {
     strcpy(name, "");
     strcpy(xml_signature, "");
     bool found_data = false;
+
+    // TODO: use XML parser
+
     while (boinc::fgets(buf, 256, in)) {
         log_messages.printf(MSG_DETAIL, "got:%s\n", buf);
         if (match_tag(buf, "<file_info>")) continue;