Merge pull request #5964 from BOINC/dpa_web13

web: remove vulnerabilities in tree_threader and in unused badge function
BOINC · Dec 19, 2024 · 949aa54 · 949aa54
2 parents 57e0bdf + b51b3e4
commit 949aa54
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/html/inc/util_ops.inc b/html/inc/util_ops.inc
@@ -331,6 +331,9 @@ function app_version_desc($avid) {
 ////// badge-related stuff
 
 function get_badge($name, $title, $image_url) {
+    $name = BoincDb::escape_string($name);
+    $title = BoincDb::escape_string($title);
+    $image_url = BoincDb::escape_string($image_url);
     $b = BoincBadge::lookup("name='$name'");
     if ($b) return $b;
     $now = time();

diff --git a/html/user/tree_threader.php b/html/user/tree_threader.php
@@ -1,5 +1,7 @@
 <?php
 
+DEPRECATED
+
 // Handler for TreeThreader remote job submission.
 //
 // Assumptions:
@@ -155,7 +157,7 @@ function handle_get_output($r, $batch) {
 
 // authenticate the user
 //
-$auth = (string)$r->auth;
+$auth = BoincDb::escape_string((string)$r->auth);
 $user = BoincUser::lookup("authenticator='$auth'");
 if (!$user) error("invalid authenticator");
 $user_submit = BoincUserSubmit::lookup_userid($user->id);