Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Add integration testing to Travis CI #2667

Merged
merged 4 commits into from
Sep 17, 2018
Merged

Conversation

ChristianBeer
Copy link
Member

This spins up a project using docker and runs some PHPUnit based tests against it.

This spins up a project using docker and runs some PHPUnit based tests against it.
This is kind of embarassing as I specifically created the new travis config in #2659 so that the integration tests (not the unit tests) can use the proper PHP environment. Somehow I mixed that up. Mea culpa.
@ChristianBeer
Copy link
Member Author

@TheAspens this is now basically working. This is still WIP as I have a few questions and comments.

  1. Where do we move the boinc-server-test repository to? As a separate repository in the BOINC organization or do we copy the files into the new integration_test directory?
  2. I would like to have colored more verbose output from PHPUnit even if all test are successful.Right now it's just a boring grey line in the Travis log. A list of green checkmarks (or whatever PHPUnit can output) is a bit more impressive.
  3. I looked into caching the docker layers and we would gain some time but this doesn't look trivial with the ansible setup we use. Right now we are still under 10 minutes runtime where the actual tests are only several seconds. So adding more tests does not add too much a burden and we are still far away from the 30 minute limit.

@TheAspens
Copy link
Member

I would suggest that we migrate the repo over to the BOINC repo. I'll do that now.

#2 is a good idea but can be done after it is running.
#3 is also good, but is a optimization for the future.

Once I create the repo and suck my code in we should open issues on the repo for these two items.

@TheAspens
Copy link
Member

@ChristianBeer
Copy link
Member Author

Thanks for moving the directory. I changed the install script. Tests are still fine.

@ChristianBeer ChristianBeer changed the title [WIP] Travis: Add integration testing to Travis CI Travis: Add integration testing to Travis CI Sep 5, 2018
@ChristianBeer
Copy link
Member Author

I just removed the WIP tag as this is ready for review now. I just want to note that the actual unit tests are in a separate repository. This is fine with me for now but we should think about moving the tests into integration_test in the future.

@TheAspens
Copy link
Member

Looks good. Thanks for doing this!

@TheAspens TheAspens merged commit a453c0c into master Sep 17, 2018
@ChristianBeer ChristianBeer deleted the cb_integration_testing branch September 20, 2018 18:07
@AenBleidd AenBleidd added this to the Client Release 7.14 milestone Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants