Use 'enum' instead of int/#define for PREEMPT_TYPE and SCHEDULER_STATE. #5363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory we should do this for everything like this; it provides some type checking and prevents passing the wrong type of value (though I don't recall this ever happening). Note: you can't parse_int() directly into an enum. You have to parse into an int, then cast to enum. Note 2: there's some funky perl code that scrapes common_defs.h for #defines and makes them into python variables. I think we can get rid of this. Also added some comments. No functional changes.
AenBleidd
approved these changes
Sep 16, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5363 +/- ##
============================================
- Coverage 10.87% 10.87% -0.01%
Complexity 1068 1068
============================================
Files 279 279
Lines 36059 36061 +2
Branches 8335 8335
============================================
Hits 3920 3920
- Misses 31745 31747 +2
Partials 394 394
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory we should do this for everything like this;
it provides some type checking and prevents passing the wrong type of value
(though I don't recall this ever happening).
Note: you can't parse_int() directly into an enum.
You have to parse into an int, then cast to enum.
Note 2: there's some funky perl code that scrapes common_defs.h
for #defines and makes them into python variables.
I think we can get rid of this.
Also added some comments.
No functional changes.