complete #5123: client and server: increase p_features size from 1024 to 8192 #5397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AenBleidd
approved these changes
Oct 16, 2023
|
@bema-aei, could you please fix the size of the boinc/sched/plan_class_spec.cpp Line 272 in 74d2d45 |
AenBleidd
approved these changes
Oct 16, 2023
|
Regarding the failes checks: "Please upload with the Codecov repository upload token to resolve issue." Nothing I can do about that. |
You can ignore them, this happens from time to time, and this is nothing related to the changes in this PR. |
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5123
In the current version of the code (master branch), p_features size of the host record is still fixed 1024. That doesn't look right (and probably won't help):
char p_features[1024];
https://github.com/BOINC/boinc/blob/master/db/boinc_db_types.h#L369