Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vboxwrapper: add the ability to share project and slot directories #5458

Merged
merged 13 commits into from
Dec 19, 2023

Conversation

davidpanderson
Copy link
Contributor

Fixes #5444

Also: change client to show filename in error msg if can't run app
Also: clean up output of update_versions

- make aid (APP_INIT_DATA) into a global
- make paths of slot and project dirs into globals
- simplify code
- report error if VBoxManage isn't found
- vbox_common.cpp: remove unnecessary includes
- if in standalone mode, don't check HW acceleration
- if in standalone mode, assume project dir is 'project'
- fix a couple of bugs

New features seem to work.
change Linux Makefile to add version# / platform to executable name

NOTE: all files that will get sent to a BOINC client
should have a version number in the filename;
if they're executable code they should also have
a platform name in the filename.

It would be nice to centralize these version numbers (like in version.h).
For now they're scattered around project files and Makefiles
- client (Win): if process creation fails,
    show the exec path in the error message (rather than '%1')
Add 'boinc_resolve' script: use within a VM to resolve soft links
(useful now that we can share the project dir)

worker (example app for Vbox tests):
    take in/out filenames as args

create_work: make the default 1 (total) result.

update_versions: add --verbose option
Copy link
Contributor

@Vulpine05 Vulpine05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things I noticed in the grammar, see enclosed comments.

samples/vboxwrapper/vbox_common.cpp Outdated Show resolved Hide resolved
samples/vboxwrapper/vbox_common.cpp Outdated Show resolved Hide resolved
samples/vboxwrapper/vbox_common.cpp Outdated Show resolved Hide resolved
@AenBleidd
Copy link
Member

I need some time to review this properly.
Please do not merge it before that.

davidpanderson and others added 3 commits December 18, 2023 16:46
Fix setting vboxwrapper and wrapper versions during build
Fix artifacts names for upload
Fix deployment script, fix artifacts upload

Signed-off-by: Vitalii Koshura <[email protected]>
@AenBleidd AenBleidd merged commit 3833dc2 into master Dec 19, 2023
77 checks passed
@AenBleidd AenBleidd deleted the dpa_vboxw_share branch December 19, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

vboxwrapper: share slot and project dirs
3 participants