-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vboxwrapper: add the ability to share project and slot directories #5458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make aid (APP_INIT_DATA) into a global - make paths of slot and project dirs into globals - simplify code - report error if VBoxManage isn't found - vbox_common.cpp: remove unnecessary includes
- if in standalone mode, don't check HW acceleration - if in standalone mode, assume project dir is 'project' - fix a couple of bugs New features seem to work.
change Linux Makefile to add version# / platform to executable name NOTE: all files that will get sent to a BOINC client should have a version number in the filename; if they're executable code they should also have a platform name in the filename. It would be nice to centralize these version numbers (like in version.h). For now they're scattered around project files and Makefiles
- client (Win): if process creation fails, show the exec path in the error message (rather than '%1')
Add 'boinc_resolve' script: use within a VM to resolve soft links (useful now that we can share the project dir) worker (example app for Vbox tests): take in/out filenames as args create_work: make the default 1 (total) result. update_versions: add --verbose option
Vulpine05
reviewed
Dec 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things I noticed in the grammar, see enclosed comments.
I need some time to review this properly. |
Fix setting vboxwrapper and wrapper versions during build Fix artifacts names for upload Fix deployment script, fix artifacts upload Signed-off-by: Vitalii Koshura <[email protected]>
AenBleidd
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5444
Also: change client to show filename in error msg if can't run app
Also: clean up output of update_versions