Compile osx manager with vcpkg #5926
Draft
+323
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talregev
force-pushed
the
TalR/osx_vcpkg5
branch
4 times, most recently
from
218bab4 to
6687500
Compare
|
Thank you for your pull request. |
There was a problem hiding this comment.
Copilot reviewed 3 out of 13 changed files in this pull request and generated no suggestions.
Files not reviewed (10)
- 3rdParty/vcpkg_ports/configs/manager/osx/vcpkg.json: Language not supported
- 3rdParty/vcpkg_ports/patches/boinc_SetItemBitmap.patch: Language not supported
- 3rdParty/vcpkg_ports/patches/boinc_SetVisibilityHidden.patch: Language not supported
- 3rdParty/vcpkg_ports/patches/pcre2.patch: Language not supported
- 3rdParty/vcpkg_ports/patches/wxwidgets.patch: Language not supported
- 3rdParty/vcpkg_ports/triplets/ci/arm64-osx.cmake: Language not supported
- 3rdParty/vcpkg_ports/triplets/ci/x64-osx.cmake: Language not supported
- mac_build/buildMacBOINC-CI.sh: Language not supported
- osx/build_vcpkg_3rdparty_for_manager.sh: Language not supported
- osx/update_vcpkg_manager_universal.sh: Language not supported
talregev
force-pushed
the
TalR/osx_vcpkg5
branch
from
6687500 to
20538f4
Compare
|
The current build system guarantees that each version of BOINC is built for MacOS with a specific versions of all the dependencies. Since vcpkg could result in the MacOS Manager being built with different versions of dependencies, I would no longer be willing to support BOINC because of the added difficulty in debugging bug reports from the field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile osx manager with vcpkg.