web: fix various XSS vulnerabilities #5968
Merged
+52
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of these involve putting user text in error messages. Use htmlspecialchars() for this. filenames: require POSIX portable names
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (7)
- html/inc/util_basic.inc: Language not supported
- html/user/get_output.php: Language not supported
- html/user/get_output3.php: Language not supported
- html/user/job_file.php: Language not supported
- html/user/openid_login.php: Language not supported
- html/user/prefs_edit.php: Language not supported
- html/user/submit_rpc_handler.php: Language not supported
AenBleidd
approved these changes
Dec 21, 2024
|
There is one small issue which I have put in the comments. |
|
Where in the comments? |
|
Just above. |
|
the comments of this PR? I'm not seeing it. |
|
"Bug 209 is still there. It would require .htmlspecialchars($req) on line 302" in job_file.php |
|
github didn't show a comment there for some reason. Anyway, fixed now |
|
LGTM |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (7)
- html/inc/util_basic.inc: Language not supported
- html/user/get_output.php: Language not supported
- html/user/get_output3.php: Language not supported
- html/user/job_file.php: Language not supported
- html/user/openid_login.php: Language not supported
- html/user/prefs_edit.php: Language not supported
- html/user/submit_rpc_handler.php: Language not supported
|
Merging this to master since this already merged to the release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these involve putting user text in error messages. Use htmlspecialchars() for this.
filenames: require POSIX portable names