html/inc/boinc_db.inc: fix $dbnum comparison in BoicDB::get() #6117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if self::$dbnum is currently 0 or 1, it as handles as a boolean value and thus the comparison with the new $ dbnum is a boolean comparison. This works for 0 or 1, but not for othe values, unless numeric values and comparison are specified explicitly.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
BoicDB::get()ifself::$dbnumis currently 0 or 1, it is handled as a boolean value and thus the comparison with the new$dbnumis a boolean comparison. This works for 0 or 1, but not for other values (like 2, which is also booleantrue). Therefore numeric values need to be specified explicitly.Fixes a problem in #5697 that slipped through during original review/testing. I had that in my MR (#5695), though, to fix the same problem.