Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs related to documentation urls. #131

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

OPSergio
Copy link
Contributor

Aplicados cambios asociados a las urls. modificadas en urls.py, documentationSideBar.html y en los distintos md.

@@ -28,5 +28,5 @@ The website stores all the processed data and metadata, and allows the visualiza


## Relecov-tools
relecov tools is a python package with helper functions for data management in the project. Read more [here](relecov_tools.md)
relecov tools is a python package with helper functions for data management in the project. Read more [here](https://github.com/BU-ISCIII/buisciii-tools)
Copy link
Member

@Shettland Shettland Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should aim to relecov-tools instead

docs/views.py Outdated
@@ -248,7 +248,9 @@ def upload_to_gisaid(request):

@login_required
def create_new_user_account(request):
converted_to_html = docs.utils.markdown.markdown_to_html("createNewUserAccount.md")
converted_to_html = docs.utils.markdown.markdown_to_html(
"create_new_user_account.md"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one should be "create_new_user.md" instead of "create_new_user_account.md"

@Shettland
Copy link
Member

This one is not urgently needed but since you fixed some links to relecov_tools.md, I think that it should be updated. Copying the current README.md from https://github.com/BU-ISCIII/relecov-tools should be enough

[![python_lint](https://github.com/BU-ISCIII/relecov-tools/actions/workflows/python_lint.yml/badge.svg)](https://github.com/BU-ISCIII/relecov-tools/actions/workflows/python_lint.yml)
[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/psf/black)

> THIS REPO IS UNDER ACTIVE DEVELOPMENT.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this line for something like "Find more information about the tools here: https://github.com/BU-ISCIII/relecov-tools"

Copy link
Member

@Shettland Shettland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Add the last change that I requested and you are ready to go

@OPSergio OPSergio merged commit 0863024 into BU-ISCIII:develop Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants