Add wasm support #754
Open
Add wasm support #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems when emscripten env is activated, make cannot execute cmake due to the same reason with emscripten-core/emsdk#616, so I have to put these in a separate script inside wasm/. |
|
如果能吧 node.js bindings 切换到 wasm 实现，那就更好了 |
septs
reviewed
Dec 26, 2022
| add_subdirectory(test) | ||
| if (NOT EMSCRIPTEN) | ||
| add_subdirectory(doc) | ||
| add_subdirectory(data) |
There was a problem hiding this comment.
wasm/build.sh里，先本地编译，然后把ocd2产物共享给wasm
可行，就是wasm速度会比native慢一些，不一定划算 |
等等作者（ @BYVoid ）的意见吧，我只是觉得 wasm 免除编译带来的优势更大（指开箱即用） |
|
my opencc算是我做my rime的一个中间产物，所以用C++版opencc是个刚需 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
做了个网站，纯前端wasm转换繁简https://my-opencc.vercel.app/ 支持全部14个json配置
代码：https://github.com/LibreService/my_opencc
想把wasm构建部分合并到上游
跟https://github.com/oyyd/wasm-opencc 的区别：
CMakeLists.txt和；wasm-opencc的改动比较大，基本没法合并Makefile