Adding explicit render to CDF generator

BabylonJS · Dec 20, 2024 · 259bd1f · 259bd1f
1 parent 878d9cf
commit 259bd1f
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 2 deletions.
diff --git a/packages/dev/core/src/Rendering/IBLShadows/iblShadowsVoxelTracingPass.ts b/packages/dev/core/src/Rendering/IBLShadows/iblShadowsVoxelTracingPass.ts
@@ -244,7 +244,7 @@ export class _IblShadowsVoxelTracingPass {
                 uniforms: ["sizeParams"],
                 samplers: ["debugSampler"],
                 engine: this._engine,
-                reusable: false,
+                reusable: true,
                 shaderLanguage: isWebGPU ? ShaderLanguage.WGSL : ShaderLanguage.GLSL,
                 extraInitializations: (useWebGPU: boolean, list: Promise<any>[]) => {
                     if (useWebGPU) {

diff --git a/packages/dev/core/src/Rendering/iblCdfGenerator.ts b/packages/dev/core/src/Rendering/iblCdfGenerator.ts
@@ -91,7 +91,7 @@ export class IblCdfGenerator {
     /** Enable the debug view for this pass */
     public debugEnabled: boolean = false;
     private _debugPass: PostProcess;
-    private _debugSizeParams: Vector4 = new Vector4(0.0, 0.0, 0.0, 0.0);
+    private _debugSizeParams: Vector4 = new Vector4(0.0, 0.0, 1.0, 1.0);
 
     /**
      * Sets params that control the position and scaling of the debug display on the screen.
@@ -337,6 +337,37 @@ export class IblCdfGenerator {
         );
     }
 
+    /**
+     * Explicitly trigger generation of CDF maps when they are ready to render.
+     * @returns Promise that resolves when the CDF maps are rendered.
+     */
+    public renderWhenReady(): Promise<void> {
+        // Once the textures are generated, notify that they are ready to use.
+        this._icdfPT.onGeneratedObservable.addOnce(() => {
+            this.onGeneratedObservable.notifyObservers();
+        });
+        const promises: Array<Promise<void>> = [];
+        const renderTargets: Array<ProceduralTexture> = [this._cdfyPT, this._cdfxPT, this._scaledLuminancePT, this._icdfPT];
+        renderTargets.forEach((target) => {
+            promises.push(
+                new Promise((resolve) => {
+                    if (target.isReady()) {
+                        resolve();
+                    } else {
+                        target.getEffect().executeWhenCompiled(() => {
+                            resolve();
+                        });
+                    }
+                })
+            );
+        });
+        return Promise.all(promises).then(() => {
+            renderTargets.forEach((target) => {
+                target.render();
+            });
+        });
+    }
+
     /**
      * Disposes the CDF renderer and associated resources
      */