KHR_materials_clearcoat_ior extension support #17185
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17185/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17185/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17185/merge#BCU1XR#0 |
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
Head branch was pushed to by a user without write access
packages/dev/serializers/src/glTF/2.0/Extensions/KHR_materials_clearcoat_ior.ts
Show resolved
Hide resolved
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
| clearcoatIor: coatIor, | ||
| }; | ||
|
|
||
| if (coatIorInfo.clearcoatIor !== null) { |
There was a problem hiding this comment.
This isn't necessary. _materialNeedsUVsSet is only relevant if the extension introduces textures.
|
|
||
| // This material must have the clearcoat extension already before | ||
| // we can add the clearcoat IOR sub-extension | ||
| const parentExt = node.extensions ? node.extensions["KHR_materials_clearcoat"] : null; |
There was a problem hiding this comment.
Ahh... we should add a way to specify what order this extension is processed, otherwise this could fail to export. Would you mind implementing the same mechanism that the glTF loader uses to order extensions?
No description provided.