Skip to content

Viewer : Add default metarial and ssao #17186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Viewer : Add default metarial and ssao #17186

wants to merge 12 commits into from

Conversation

alexandremottet
Copy link
Contributor

@alexandremottet alexandremottet commented Sep 23, 2025 •
edited
Loading

@ryantrem and/or others for review

Change the default material if the model has non provided.
Sep-23-2025 17-05-12

Add support for SSAO for "uniform" assets
Sep-23-2025 17-06-07

@alexandremottet alexandremottet changed the title Add default metarial and ssao Viewer : Add default metarial and ssao Sep 23, 2025
sebavan
sebavan reviewed Sep 23, 2025
View reviewed changes
ryantrem
ryantrem approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@ryantrem ryantrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for this contribution!

Can you also either make the changes for or open issues for:

  • Updating the docs.
  • Updating the configurator.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Snapshot stored with reference name:
refs/pull/17186/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17186/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17186/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17186/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17186/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17186/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/devhostplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/devhostplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/webgpuplaywright/index.html

@alexandremottet alexandremottet mentioned this pull request Sep 24, 2025
Merged
@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/devhostplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/webgpuplaywright/index.html

sebavan pushed a commit to BabylonJS/Documentation that referenced this pull request Sep 24, 2025
@alexandremottet
Viewer: add SSAO attribute (#1401)
60e428e 
Documentation for this PR :
BabylonJS/Babylon.js#17186
@ryantrem
Copy link
Member

@alexandremottet I pushed a couple fixes, including for a regression that was breaking one of the automated tests.

ryantrem
ryantrem reviewed Sep 24, 2025
View reviewed changes
Copy link
Member

@ryantrem ryantrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on one side conversation...

ryantrem
ryantrem requested changes Sep 24, 2025
View reviewed changes
Copy link
Member

@ryantrem ryantrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on one side conversation...

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/interactionplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/devhostplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 24, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17186/merge/testResults/webgpuplaywright/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantrem ryantrem ryantrem approved these changes

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandremottet @bjsplat @ryantrem @sebavan