Skip to content

Conversation

georginahalpern
Copy link
Contributor

Rather than multiplying epsilon by a const speed when determining if movement is small enough to be clamped to 0, we are now multiplying epsilon by the localSpeed (which takes framerate into account).

This helps avoid inconsistent motion behavior on higher framerate devices, described in this forum post.

https://forum.babylonjs.com/t/camera-inertia-causes-inconsistent-motion/60633/11

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@ReedSyllas
Copy link

Hi!

Does speed need to be included in the calculation at arcRotateCamera.ts:1066 and arcRotateCamera.ts:1069? I can see that this.speed isn't there, but I think it should've been?

From my personal testing it seems required. The bad behavior comes back without it.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2025

@sebavan sebavan marked this pull request as draft September 25, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants