Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make boat-maven-plugin goal doc to run in Java 17. #938

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Make boat-maven-plugin goal doc to run in Java 17. #938

merged 2 commits into from
Oct 17, 2024

Conversation

fredysierra
Copy link
Contributor

When running boat-maven-plugin goal doc. With parameters:

<engine>handlebars</engine>
<generatorName>boat-marina</generatorName>

New version of the plugin requires Java 17 and this goal does not work in Java 17

Additionally, model doc generated ignores Array type fields. Those are not shown in Portal Api and those produce inconsistencies in the documentation.

For that, BoatMarinaGenerator was changed with property generateAliasAsModel as true

Copy link

sonarcloud bot commented Oct 11, 2024

Copy link
Contributor

@jjjasper jjjasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add test coverage for these goals?

@santam85 santam85 merged commit 791dbf4 into main Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants