Feat/db

.carve/config.edn

@@ -1,9 +1,12 @@
 {;; Only lint production namespaces as most dev
  ;; namespaces are unused
- :paths ["src/main" "src/electron" "src/test"]
- :api-namespaces [
-                  ;; Ignore b/c too many false positives
+ :paths ["src/main" "src/electron" "src/test" "src/rtc_e2e_test"]
+ :api-namespaces [;; Ignore b/c too many false positives
                   frontend.db
                   ;; Used for debugging
-                  frontend.db.debug]
+                  frontend.db.debug
+                  frontend.worker.debug
+                  ;; Ignore because of dev work
+                  helper
+                  logseq.api]
  :report {:format :ignore}}

.carve/ignore

@@ -2,8 +2,6 @@
 electron.core/main
 electron.core/start
 electron.core/stop
-;; repl fn
-electron.search/query
 ;; Used by shadow-cljs
 frontend.core/stop
 ;; For repl
@@ -37,24 +35,13 @@ frontend.fs/readdir
 ;; Referenced in TODO
 frontend.handler.metadata/update-properties!
 ;; Referenced in comment
-frontend.handler.route/toggle-between-page-and-file!
-;; Referenced in comment
-frontend.handler.shell/run-pandoc-command!
-;; Referenced in comment
 frontend.image/get-orientation
 ;; For debugging
 frontend.mixins/perf-measure-mixin
 ;; Previously useful fn
 frontend.mobile.util/get-idevice-statusbar-height
-;; Used in macro
-frontend.modules.outliner.datascript/transact!
-frontend.modules.outliner.core/*transaction-opts*
-;; Referenced in comment
-frontend.page/route-view
 ;; placeholder fn
 frontend.publishing/stop
-;; Referenced in comment
-frontend.state/set-db-persisted!
 ;; Future use
 frontend.storage/get-transit
 ;; repl fn
@@ -74,7 +61,7 @@ frontend.util/trace!
 ;; Repl fn
 frontend.util.pool/terminate-pool!
 ;; Repl fn
-frontend.util.property/add-page-properties
+frontend.handler.file-based.property.util/add-page-properties
 ;; Test runners used by shadow
 frontend.test.node-test-runner/main
 frontend.test.frontend-node-test-runner/main
@@ -85,3 +72,19 @@ frontend.fs.sync/debug-print-sync-events-loop
 frontend.fs.sync/stop-debug-print-sync-events-loop
 ;; Used in macro
 frontend.state/get-current-edit-block-and-position
+;; For debugging
+frontend.db.model/get-all-classes
+;; Initial loaded
+frontend.ui/_emoji-init-data
+;; placeholder var for defonce
+frontend.worker.rtc.op-mem-layer/_sync-loop-canceler
+;; Used by shadow.cljs
+frontend.worker.db-worker/init
+;; Future use?
+frontend.worker.rtc.hash/hash-blocks
+;; Repl fn
+frontend.rum/use-atom-in
+;; missionary utils
+frontend.common.missionary/<!
+;; only used in deps/common
+frontend.common.missionary/background-task-running?

.clj-kondo/config.edn

@@ -3,16 +3,26 @@
  :config-in-ns
  ;; :used-underscored-binding is turned off for components because of false positive
  ;; for rum/defcs and _state.
- {all-components {:linters {:used-underscored-binding {:level :off}}}
+ {all-components
+  {:linters {:used-underscored-binding {:level :off}}}
   ;; false positive with match/match and _
   frontend.handler.paste {:linters {:used-underscored-binding {:level :off}}}
   frontend.db {:linters {:aliased-namespace-symbol
-                         {:exclude [frontend.db.conn frontend.db.react logseq.db.default]}}}}
+                         {:exclude [frontend.db.conn frontend.db.react]}}}}
 
  :linters
  {:path-invalid-construct/string-join {:level :info}
+  :defkeywords/invalid-arg {:level :warning}
   :regex-checks/double-escaped-regex {:level :warning}
   :aliased-namespace-symbol {:level :warning}
+  :shadowed-var {:level :warning
+                 :exclude [key val name binding type uuid
+                           ;; FIXME: Remove the shadowed below as shadowing core fns isn't a good practice
+                           ;; FIXME: At least remove the first two lines as they have few uses
+                           re-pattern sequence dispatch-fn comp vec delay chunk
+                           fn t ex-data list int? hash range
+                           time sort-by namespace count parents exists? min
+                           new var ns resolve identity next meta vals keys exists?]}
   ;; Disable until it doesn't trigger false positives on rum/defcontext
   :earmuffed-var-not-dynamic {:level :off}
   ;; Disable until we decide to use conj! as recommended in docs
@@ -21,6 +31,18 @@
                                 goog.string.unescapeEntities
                                 ;; TODO:lint: Fix when fixing all type hints
                                 object]}
+
+  :discouraged-namespace
+  {logseq.db.sqlite.cli {:message "frontend should not depend on CLI namespace with sqlite3 dependency"}
+   logseq.outliner.cli {:message "frontend should not depend on CLI namespace with sqlite3 dependency"}}
+  :discouraged-var
+  {rum.core/use-effect! {:message "Use frontend.hooks/use-effect! instead" :level :info}
+   rum.core/use-memo {:message "Use frontend.hooks/use-memo instead" :level :info}
+   rum.core/use-layout-effect! {:message "Use frontend.hooks/use-layout-effect! instead" :level :info}
+   rum.core/use-callback {:message "Use frontend.hooks/use-callback instead" :level :info}}
+  :unused-namespace {:level :warning
+                     :exclude [logseq.db.frontend.entity-plus]}
+
   ;; TODO:lint: Remove node-path excludes once we have a cleaner api
   :unresolved-var {:exclude [frontend.util/node-path.basename
                              frontend.util/node-path.dirname
@@ -31,91 +53,150 @@
                              frontend.pubsub]}
 
   :consistent-alias
-  {:aliases {cljs.reader reader
-             cljs-time.core t
+  {:aliases {"/electron/utils" js-utils
+             "path" node-path
              cljs-time.coerce tc
+             cljs-time.core t
+             cljs.reader reader
+             clojure.string string
              datascript.core d
-             datascript.transit dt
              datascript.db ddb
+             datascript.transit dt
              electron.ipc ipc
              electron.utils utils
-             "/electron/utils" js-utils
              frontend.commands commands
+             frontend.common.date common-date
+             frontend.common.file.core common-file
+             frontend.common.file.util wfu
+             frontend.common.missionary-util c.m
+             frontend.common.schema-register sr
+             frontend.common.search-fuzzy fuzzy
              frontend.components.block.macros block-macros
+             frontend.components.class class-component
+             frontend.components.property property-component
              frontend.components.query query
              frontend.components.query.result query-result
+             frontend.components.title title
              frontend.config config
              frontend.date date
              frontend.db db
              frontend.db-mixins db-mixins
+             frontend.db.query-custom query-custom
              frontend.db.query-dsl query-dsl
-             frontend.db.react react
              frontend.db.query-react query-react
+             frontend.db.react react
              frontend.db.util db-utils
              frontend.diff diff
              frontend.encrypt encrypt
              frontend.extensions.sci sci
-             frontend.format.mldoc mldoc
              frontend.format.block block
+             frontend.format.mldoc mldoc
              frontend.fs fs
-             frontend.fs.memory-fs memory-fs
              frontend.fs.capacitor-fs capacitor-fs
+             frontend.fs.memory-fs memory-fs
              frontend.fs.nfs nfs
-             frontend.handler.extract extract
              frontend.handler.common common-handler
+             frontend.handler.common.developer dev-common-handler
              frontend.handler.common.file file-common-handler
+             frontend.handler.common.page page-common-handler
              frontend.handler.common.plugin plugin-common-handler
-             frontend.handler.common.developer dev-common-handler
              frontend.handler.config config-handler
+             frontend.handler.db-based.editor db-editor-handler
+             frontend.handler.db-based.page db-page-handler
+             frontend.handler.db-based.property db-property-handler
+             frontend.handler.db-based.property.util db-pu
              frontend.handler.editor.property editor-property
              frontend.handler.events events
+             frontend.handler.extract extract
+             frontend.handler.file-based.page file-page-handler
+             frontend.handler.file-based.page-property file-page-property
+             frontend.handler.file-based.property file-property-handler
+             frontend.handler.file-based.property.util property-util
+             frontend.handler.file-based.recent file-recent-handler
+             frontend.handler.file-based.repo file-repo-handler
              frontend.handler.global-config global-config-handler
-             frontend.handler.ui ui-handler
              frontend.handler.notification notification
              frontend.handler.page page-handler
              frontend.handler.plugin plugin-handler
              frontend.handler.plugin-config plugin-config-handler
+             frontend.handler.property.file property-file
+             frontend.handler.property.util pu
              frontend.handler.query.builder query-builder
              frontend.handler.repo repo-handler
              frontend.handler.repo-config repo-config-handler
              frontend.handler.route route-handler
              frontend.handler.search search-handler
+             frontend.handler.ui ui-handler
+             frontend.hooks hooks
              frontend.idb idb
              frontend.loader loader
              frontend.mixins mixins
              frontend.mobile.util mobile-util
+             frontend.modules.outliner.ui ui-outliner-tx
              frontend.page page
+             frontend.persist-db persist-db
              frontend.schema.handler.common-config common-config-schema
              frontend.search search
              frontend.state state
              frontend.template template
              frontend.test.helper test-helper
              frontend.ui ui
              frontend.util util
-             frontend.util.clock clock
+             frontend.util.file-based.clock clock
+             frontend.util.file-based.drawer drawer
              frontend.util.page page-util
-             frontend.util.property property
              frontend.util.persist-var persist-var
+             frontend.util.property property
              frontend.util.text text-util
-             frontend.util.url url-util
              frontend.util.thingatpt thingatpt
+             frontend.util.url url-util
+             frontend.worker.handler.page worker-page
+             frontend.worker.pipeline worker-pipeline
+             frontend.worker.state worker-state
+             frontend.worker.util worker-util
              lambdaisland.glogi log
-             logseq.common.path path
-             logseq.common.graph common-graph
              logseq.common.config common-config
+             logseq.common.date-time-util date-time-util
+             logseq.common.graph common-graph
+             logseq.common.path path
+             logseq.common.util common-util
+             logseq.common.util.block-ref block-ref
+             logseq.common.util.macro macro-util
+             logseq.common.util.namespace ns-util
+             logseq.common.util.page-ref page-ref
+             logseq.db ldb
+             logseq.db.frontend.class db-class
+             logseq.db.frontend.content db-content
+             logseq.db.frontend.db-ident db-ident
+             logseq.db.frontend.entity-plus entity-plus
+             logseq.db.frontend.entity-util entity-util
+             logseq.db.frontend.inputs db-inputs
+             logseq.db.frontend.order db-order
+             logseq.db.frontend.property db-property
+             logseq.db.frontend.property.build db-property-build
+             logseq.db.frontend.property.type db-property-type
+             logseq.db.frontend.property.util db-property-util
+             logseq.db.frontend.rules rules
+             logseq.db.frontend.schema db-schema
+             logseq.db.frontend.validate db-validate
+             logseq.db.sqlite.cli sqlite-cli
+             logseq.db.sqlite.util sqlite-util
+             logseq.db.test.helper db-test
              logseq.graph-parser graph-parser
-             logseq.graph-parser.text text
              logseq.graph-parser.block gp-block
+             logseq.graph-parser.db gp-db
              logseq.graph-parser.mldoc gp-mldoc
-             logseq.graph-parser.util gp-util
              logseq.graph-parser.property gp-property
-             logseq.graph-parser.config gp-config
-             logseq.graph-parser.util.page-ref page-ref
-             logseq.graph-parser.util.block-ref block-ref
-             logseq.graph-parser.util.db db-util
-             logseq.graph-parser.date-time-util date-time-util
+             logseq.graph-parser.text text
+             logseq.outliner.batch-tx batch-tx
+             logseq.outliner.core outliner-core
+             logseq.outliner.datascript-report ds-report
+             logseq.outliner.op outliner-op
+             logseq.outliner.pipeline outliner-pipeline
+             logseq.outliner.validate outliner-validate
+             logseq.shui.popup.core shui-popup
+             logseq.shui.ui shui
              medley.core medley
-             "path" node-path
              promesa.core p}}
 
   :namespace-name-mismatch {:level :warning}
@@ -124,21 +205,24 @@
  :hooks {:analyze-call {rum.core/defc hooks.rum/defc
                         rum.core/defcs hooks.rum/defcs
                         clojure.string/join hooks.path-invalid-construct/string-join
-                        clojure.string/replace hooks.regex-checks/double-escaped-regex}}
+                        clojure.string/replace hooks.regex-checks/double-escaped-regex
+                        logseq.common.defkeywords/defkeywords hooks.defkeywords/defkeywords}}
  :lint-as {promesa.core/let clojure.core/let
            promesa.core/loop clojure.core/loop
            promesa.core/recur clojure.core/recur
+           promesa.core/doseq clojure.core/doseq
            rum.core/defcc rum.core/defc
            rum.core/with-context clojure.core/let
            rum.core/defcontext clojure.core/def
            clojure.test.check.clojure-test/defspec clojure.core/def
            clojure.test.check.properties/for-all clojure.core/for
            ;; src/main
-           frontend.modules.outliner.datascript/auto-transact! clojure.core/let
            frontend.namespaces/import-vars potemkin/import-vars
            ;; src/test
            frontend.test.helper/deftest-async clojure.test/deftest
-           frontend.test.helper/with-reset cljs.test/async
-           frontend.react/defc clojure.core/defn}
+           frontend.worker.rtc.idb-keyval-mock/with-reset-idb-keyval-mock cljs.test/async
+           frontend.react/defc clojure.core/defn
+           logseq.common.defkeywords/defkeyword cljs.spec.alpha/def}
  :skip-comments true
- :output {:progress true}}
+ :output {:progress true
+          :exclude-files ["src/test/docs-0.10.9/"]}}

.clj-kondo/hooks/defkeywords.clj

@@ -0,0 +1,27 @@
+(ns hooks.defkeywords
+  (:require [clj-kondo.hooks-api :as api]))
+
+(defn defkeywords
+  [{:keys [node]}]
+  (let [[_ & keyvals] (:children node)
+        kw->v (partition 2 keyvals)
+        kws (map first kw->v)]
+    (cond
+      (odd? (count keyvals))
+      (api/reg-finding!
+       (assoc (meta node)
+              :message "Require even number of args"
+              :type :defkeywords/invalid-arg))
+      (not (every? (comp qualified-keyword? api/sexpr) kws))
+      (api/reg-finding!
+       (assoc (meta node)
+              :message "Should use qualified-keywords"
+              :type :defkeywords/invalid-arg))
+      :else
+      (let [new-node (api/list-node
+                      (map (fn [[kw v]]
+                             (api/list-node
+                              [(api/token-node 'logseq.common.defkeywords/defkeyword) kw v]))
+                           kw->v))]
+        {:node (with-meta new-node
+                 (meta node))}))))

.cljfmt.edn

@@ -0,0 +1,3 @@
+ {:extra-indents {missionary.core/sp [[:block 0]]
+                  missionary.core/ap [[:block 0]]}
+  :sort-ns-references? true}

.github/workflows/build-android.yml

@@ -42,7 +42,7 @@ on:
 
 env:
   CLOJURE_VERSION: '1.11.1.1413'
-  NODE_VERSION: '18'
+  NODE_VERSION: '20'
   JAVA_VERSION: '17'
 
 jobs: