Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAH -1981 | Validate and update script to delete all patient data from Bahmni #25

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Rkum113
Copy link

@Rkum113 Rkum113 commented Apr 11, 2023

No description provided.

@gsluthra
Copy link
Contributor

To summarize, it seems you have:

  1. Moved the functions which delete data for ELIS+ERP into one file.
  2. Added support for executing these command inside docker services.

Is my understanding correct? Are there any other changes? Is this tested for v0.93 or Bahmni LITE?

Note: Not everyone uses docker with Bahmni. We may need an option when people run this command to say.. are you running this for docker, or running this on plan OS (like if people want to run this script on Centos/Vagrant Box). Maybe a switch that you pass to function saying runOnDocker. If this is true then docker exec is executed, else it is skipped.

@gsluthra
Copy link
Contributor

In Bahmni LITE, people also use Crater instead of OpenERP/Odoo. We will also need a script to drop all CRATER data in future. FYI.

@Rkum113
Copy link
Author

Rkum113 commented Apr 19, 2023

To summarize, it seems you have:

  1. Moved the functions which delete data for ELIS+ERP into one file.
  2. Added support for executing these command inside docker services.

Is my understanding correct? Are there any other changes? Is this tested for v0.93 or Bahmni LITE?

Note: Not everyone uses docker with Bahmni. We may need an option when people run this command to say.. are you running this for docker, or running this on plan OS (like if people want to run this script on Centos/Vagrant Box). Maybe a switch that you pass to function saying runOnDocker. If this is true then docker exec is executed, else it is skipped.

@gsluthra, Yes i have moved delete patients data function into one script for the OpenELIS, OpenERP, OpenMRS , and i have tested for bahmni lite in docker, i will add that flag runOnDocker which you have suggested, and will try on vagrant box.

@gsluthra
Copy link
Contributor

The previous script used environment variables to set DB connection creds. In the modified scripts now the default credentials are hardcoded. I think we should continue to provide the ability to use env variables to execute commands. Maybe set variables in start of the script, and re-use them at bottom, so people can edit them before running the script?

@Rkum113
Copy link
Author

Rkum113 commented Apr 20, 2023

The previous script used environment variables to set DB connection creds. In the modified scripts now the default credentials are hardcoded. I think we should continue to provide the ability to use env variables to execute commands. Maybe set variables in start of the script, and re-use them at bottom, so people can edit them before running the script?

Ok, I will change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants