Added @jsonproperty binding to OpenMRSObservation domain model #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added @JsonProperty binding to OpenMRSObservation domain model to prevent observations with coded values to cause a parse error as caused by forms created using implementers interface with no grouping of concepts used. This is true when creating an observation form in implementers interface by using individual concepts with coded data types without grouping them as concept sets. In such cases, the encounter API will return the observations ungrouped and the value of those observations will be a json object (since it is a coded value). This will result in a parse error as the bind for value expects it to be a string. Since there will always be a property "valueAsString" in each observation returned by the API, it will be better to bind that to the "value" property of the OpenMRSObservation object.
#23
To duplicate this issue:
Attached is partial (relevant) output a got from bahmni-erp-connect log
openerp-feed-service.log