Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAH-4033 | Enhancement. Support for passing task type through eventConfig.json #71

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mohan-13
Copy link
Member

With the view of allowing implementers to allow configuring task types for the non-medication tasks, this PR brings in changes to read the task type from eventsConfig.json. This removes the hardcoding of nursing_activity_system as the task type for system generated tasks.

@mohan-13
Copy link
Member Author

Relates to Bahmni/openmrs-module-fhir2Extension#65

@mohan-13
Copy link
Member Author

⚠️ Breaking Change ⚠️
This PR brings in a breaking change to existing implementations.

  1. Contract of eventsConfig.json
  • type attribute in ConfigDetail model is updated as event
  • Additional nullable property type is introduced in TaskDetail model
  • Sample eventsConfig.json
[
{
  "event": "PATIENT_ADMIT",
  "tasks": [
    {
      "name": "Complete Insurance Pre-Auth Form",
      "type": "Documentation"
    }
  ]
},
{
  "event": "SHIFT_START_TASK",
  "tasks": []
},
{
  "event": "ROLLOVER_TASK",
  "tasks": []
}
]
  1. Exception is thrown when the concept does not exist.
    When a taskType is passed and the concept is not available in the concept dictionary, then a Validation exception is thrown.

cc. @binduak @Arjun-Go @kavitha-sundararajan

@mohan-13 mohan-13 merged commit ebd616e into main Jul 23, 2024
2 checks passed
@mohan-13 mohan-13 deleted the BAH-4033 branch July 23, 2024 05:59
kavitha-sundararajan added a commit that referenced this pull request Aug 28, 2024
* BAH-3842 | Add. Application Properties In API Resources (#60)

* BAH-3842 | Add. Application Properties In API Resources (#61)

* Merge IPD Branch Latest Changes To Master

* Parvathy | BAH-4017 | Add. Global Property bahmni-ipd.allowSlotStopOnDrugOrderStop (#69)

* BAH-4001 | Add. Set flag to mark system generated tasks (#70)

* BAH-4033 | Refactor. Get task type for system generated tasks from configuration (#71)

* BAH-4062 | Refactor. Move privilege creation to config.xml (#72)

* BAH-4062 | Refactor. Extract privilege creation to config.xml

* BAH-4062 | Fix. Error messages for privilege check failures

* BAH-4073 | Refactor. Change LICENSE to OMRS MPLv2 (#74)

* BAH-4073 | Refactor. Change LICENSE to OMRS MPLv2

* BAH-4073 | Fix. License information in pom.xml

* BAH-4061 | Refactor. Change Medication Administration Status Type As VarChar (#73)

* [Rahul] | BAH-4061 | Refactor. Change Medication Administration Status Type As VarChar

* [Rahul] | BAH-4061 | Refactor. Remove Unused Dependencies

* [Rahul] | BAH-4061 | Refactor. Change Status Value In Test

* [Rahul] | BAH-4061 | Refactor. Remove MedicationAdministration Status Null Check

* [Rahul] | BAH-4061 | Fix. MedicationAdministrationStatus Test Data

* Merge main branch changes

* BAH-4093 | Add. Workflow to release artifacts on push of a tag (#77)

* BAH-4093 | Upgrade depencies for release

* BAH-4093 | Release of version 1.0.0

* BAH-4093 | Incrementing dev version to 1.1.0-SNAPSHOT

---------

Co-authored-by: Rahul Ramesh <[email protected]>
Co-authored-by: Parvathy Babu <[email protected]>
Co-authored-by: MOHANKUMAR T <[email protected]>
Co-authored-by: MOHANKUMAR T <[email protected]>
kavitha-sundararajan added a commit that referenced this pull request Sep 15, 2024
* Parvathy | BAH-4017 | Add. Global Property bahmni-ipd.allowSlotStopOnDrugOrderStop (#69)

* BAH-4001 | Add. Set flag to mark system generated tasks (#70)

* BAH-4033 | Refactor. Get task type for system generated tasks from configuration (#71)

* BAH-4062 | Refactor. Move privilege creation to config.xml (#72)

* BAH-4062 | Refactor. Extract privilege creation to config.xml

* BAH-4062 | Fix. Error messages for privilege check failures

* BAH-4073 | Refactor. Change LICENSE to OMRS MPLv2 (#74)

* BAH-4073 | Refactor. Change LICENSE to OMRS MPLv2

* BAH-4073 | Fix. License information in pom.xml

* BAH-4061 | Refactor. Change Medication Administration Status Type As VarChar (#73)

* [Rahul] | BAH-4061 | Refactor. Change Medication Administration Status Type As VarChar

* [Rahul] | BAH-4061 | Refactor. Remove Unused Dependencies

* [Rahul] | BAH-4061 | Refactor. Change Status Value In Test

* [Rahul] | BAH-4061 | Refactor. Remove MedicationAdministration Status Null Check

* [Rahul] | BAH-4061 | Fix. MedicationAdministrationStatus Test Data

* BAH-4093 | Add. Workflow to release artifacts on push of a tag (#77)

* BAH-4093 | Upgrade depencies for release

* BAH-4093 | Release of version 1.0.0

* BAH-4093 | Incrementing dev version to 1.1.0-SNAPSHOT

* BAH-4093 | Add. Default value for config file path property. (#80)

* BAH-4093 | Add. Default value for config file path property.

* BAH-4093 | Refactor. Update property name

* BAH-4096 | Use xml based bean creations and removed annotations (#79)

* BAH-4096 | Use xml based bean creations and removed annotations

* BAH-4096 | Fix. Remove unused component scans

* BAH-4096 | Refactor. Remove ununsed properties files in OMOD

* BAH-4096 | Refactor. Move OMOD class files inside web package

* BAH-4096 | Fix. Import path in OMOD test

* Kavitha,Vikram|add emergency medication check for care view (#75) (#81)

* BAH-4093 | Release of version 1.1.0

* updated drug order response

* updated pom and workflow file

* add beans for ipd schedulers

---------

Co-authored-by: Arjun-Go <[email protected]>
Co-authored-by: Rahul Ramesh <[email protected]>
Co-authored-by: Parvathy Babu <[email protected]>
Co-authored-by: MOHANKUMAR T <[email protected]>
Co-authored-by: MOHANKUMAR T <[email protected]>
kavitha-sundararajan added a commit that referenced this pull request Sep 15, 2024
* Parvathy | BAH-4017 | Add. Global Property bahmni-ipd.allowSlotStopOnDrugOrderStop (#69)

* BAH-4001 | Add. Set flag to mark system generated tasks (#70)

* BAH-4033 | Refactor. Get task type for system generated tasks from configuration (#71)

* BAH-4062 | Refactor. Move privilege creation to config.xml (#72)

* BAH-4062 | Refactor. Extract privilege creation to config.xml

* BAH-4062 | Fix. Error messages for privilege check failures

* BAH-4073 | Refactor. Change LICENSE to OMRS MPLv2 (#74)

* BAH-4073 | Refactor. Change LICENSE to OMRS MPLv2

* BAH-4073 | Fix. License information in pom.xml

* BAH-4061 | Refactor. Change Medication Administration Status Type As VarChar (#73)

* [Rahul] | BAH-4061 | Refactor. Change Medication Administration Status Type As VarChar

* [Rahul] | BAH-4061 | Refactor. Remove Unused Dependencies

* [Rahul] | BAH-4061 | Refactor. Change Status Value In Test

* [Rahul] | BAH-4061 | Refactor. Remove MedicationAdministration Status Null Check

* [Rahul] | BAH-4061 | Fix. MedicationAdministrationStatus Test Data

* BAH-4093 | Add. Workflow to release artifacts on push of a tag (#77)

* BAH-4093 | Upgrade depencies for release

* BAH-4093 | Release of version 1.0.0

* BAH-4093 | Incrementing dev version to 1.1.0-SNAPSHOT

* BAH-4093 | Add. Default value for config file path property. (#80)

* BAH-4093 | Add. Default value for config file path property.

* BAH-4093 | Refactor. Update property name

* BAH-4096 | Use xml based bean creations and removed annotations (#79)

* BAH-4096 | Use xml based bean creations and removed annotations

* BAH-4096 | Fix. Remove unused component scans

* BAH-4096 | Refactor. Remove ununsed properties files in OMOD

* BAH-4096 | Refactor. Move OMOD class files inside web package

* BAH-4096 | Fix. Import path in OMOD test

* Kavitha,Vikram|add emergency medication check for care view (#75) (#81)

* BAH-4093 | Release of version 1.1.0

* updated drug order response

* updated pom and workflow file

* add beans for ipd schedulers

* Kavitha | update versions, beans and schedulers

---------

Co-authored-by: Arjun-Go <[email protected]>
Co-authored-by: Rahul Ramesh <[email protected]>
Co-authored-by: Parvathy Babu <[email protected]>
Co-authored-by: MOHANKUMAR T <[email protected]>
Co-authored-by: MOHANKUMAR T <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant