enhance: validate snapshot task #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyzxw
force-pushed
the
feat/validate-snapshot-task
branch
from
fbb3917 to
bcabfa8
Compare
kebe7jun
reviewed
Aug 14, 2024
| }, &pod) | ||
| if err != nil { | ||
| if errors.IsNotFound(err) { | ||
| spt.Status.Conditions = append(spt.Status.Conditions, metav1.Condition{ |
There was a problem hiding this comment.
这个在 Reconcile 中应该会统一处理。
kube-snapshot/internal/controller/snapshotpodtask_controller.go
Lines 177 to 194 in 90e4c2e
There was a problem hiding this comment.
我看没有吧，目的是当pod或者contanier不存在的时候就不需要重复的调谐了，直接标记状态为failed
yyzxw
force-pushed
the
feat/validate-snapshot-task
branch
from
bcabfa8 to
871e776
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail fast when pod or container not found