Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled updates to core pools JSON #599

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 7, 2025

Checks before merging:

@gosuto-inzasheru
Copy link
Collaborator

@jalbrekt85 this is what the new core pools will look like

before merging, can you confirm the allocator will be able to handle the v3 pools?

@gosuto-inzasheru gosuto-inzasheru marked this pull request as draft February 7, 2025 09:24
@jalbrekt85
Copy link
Contributor

jalbrekt85 commented Feb 7, 2025

@jalbrekt85 this is what the new core pools will look like

before merging, can you confirm the allocator will be able to handle the v3 pools?

yup, successfully ran v2 with new list here on my open pr:
https://github.com/BalancerMaxis/protocol_fee_allocator_v2/actions/runs/13208114479/job/36875988466?pr=39

@jalbrekt85
Copy link
Contributor

yup, successfully ran v2 with new list here: https://github.com/BalancerMaxis/protocol_fee_allocator_v2/actions/runs/13208114479/job/36875988466?pr=39

btw v3 pools require different fee calculation method, not yet added to that pr so dont merge this yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants