Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIP-797] Wire Up V3 Protocol Fee Processing Permissions #1817

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

gosuto-inzasheru
Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru commented Mar 11, 2025

Copy link
Contributor

github-actions bot commented Mar 11, 2025

FILENAME: BIPs/2025-W13/BIP-797-Wire-Up-V3-Protocol-Fee-arbitrum.json
COMMIT: 6b502d3271d02dce69738920bd9826248ff37274

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W13/BIP-797-Wire-Up-V3-Protocol-Fee-base.json
COMMIT: 6b502d3271d02dce69738920bd9826248ff37274

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W13/BIP-797-Wire-Up-V3-Protocol-Fee-ethereum.json
COMMIT: 6b502d3271d02dce69738920bd9826248ff37274

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

FILENAME: BIPs/2025-W13/BIP-797-Wire-Up-V3-Protocol-Fee-gnosis.json
COMMIT: 6b502d3271d02dce69738920bd9826248ff37274

Validator Result
validate_contains_msig
validate_msig_in_address_book
validate_chain_specified
validate_file_has_bip
validate_path_has_weekly_dir

Copy link
Contributor

github-actions bot commented Mar 11, 2025

FILENAME: BIPs/2025-W13/BIP-797-Wire-Up-V3-Protocol-Fee-arbitrum.json
MULTISIG: multisigs/dao (arbitrum:0xaF23DC5983230E9eEAf93280e312e57539D098D0)
COMMIT: 6b502d3271d02dce69738920bd9826248ff37274
CHAIN(S): arbitrum
TENDERLY: 🟩 SUCCESS

+-----------------------+-----------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name                                         | caller_address                             | fx_paths                                                                                                               | action_ids                                                         |   bip   | tx_index |
+-----------------------+-----------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | 20250228-v3-protocol-fee-sweeper/ProtocolFeeSweeper | 0x3BEb058DE1A25dd24223fd9e1796df8589429AcE | 20250214-v3-protocol-fee-controller-v2/ProtocolFeeController/withdrawProtocolFeesForToken(address,address,address)     | 0x610537725ddaed423abcb2b23d9191781b990fceb0f445f4bfe56f049514ff4c | BIP-797 |    0     |
|                       |                                                     |                                            | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/burn(address,address,uint256,address,uint256,address,uint256)         | 0x6aa2fbc777c1fe11064a1a4e6420cb1637f411cd57d0854ea9da9637aae0d174 |         |          |
| Authorizer/grantRoles | EOA/keepers/v3_fee_bot                              | 0x74E283B985EA76c55C8B48d6bD1067a418188424 | 20250228-v3-protocol-fee-sweeper/ProtocolFeeSweeper/sweepProtocolFeesForToken(address,address,uint256,uint256,address) | 0x87be93afebd07695507f864bdc3acd218608d59e5a1efb451bb946c29492977e | BIP-797 |    1     |
| Authorizer/grantRoles | multisigs/maxi_omni                                 | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/cancelOrder(address,address)                                          | 0x00142331d7b417bd388d6cdd7a18804ec88fb10c7ec23a708c6dd1a68ce3e31f | BIP-797 |    2     |
|                       |                                                     |                                            | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/emergencyCancelOrder(address,address)                                 | 0x31be246c868693f3fe64ae2f6f3df8edc2881356e44ab9cc7261c77bfc96a158 |         |          |
|                       |                                                     |                                            | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/retryOrder(address,uint256,uint256)                                   | 0xfb02a100d873c2a489494f0f78d4d6fd83a4d948855b8251fcd4969afa0efea9 |         |          |
+-----------------------+-----------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W13/BIP-797-Wire-Up-V3-Protocol-Fee-base.json
MULTISIG: multisigs/dao (base:0xC40DCFB13651e64C8551007aa57F9260827B6462)
COMMIT: 6b502d3271d02dce69738920bd9826248ff37274
CHAIN(S): base
TENDERLY: 🟩 SUCCESS

+-----------------------+-----------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name                                         | caller_address                             | fx_paths                                                                                                               | action_ids                                                         |   bip   | tx_index |
+-----------------------+-----------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | 20250228-v3-protocol-fee-sweeper/ProtocolFeeSweeper | 0x83E443EF4f9963C77bd860f94500075556668cb8 | 20250214-v3-protocol-fee-controller-v2/ProtocolFeeController/withdrawProtocolFeesForToken(address,address,address)     | 0x0ef595d0eed0a6e5adfc1fe810c72ad3d4b23e7c0d66a74fd4799e2f799af0bf | BIP-797 |    0     |
|                       |                                                     |                                            | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/burn(address,address,uint256,address,uint256,address,uint256)         | 0x92e4be06c4f8a949c6b6b835439571e9e454f57e7585734aa3fcbe9f3008aa83 |         |          |
| Authorizer/grantRoles | EOA/keepers/v3_fee_bot                              | 0x74E283B985EA76c55C8B48d6bD1067a418188424 | 20250228-v3-protocol-fee-sweeper/ProtocolFeeSweeper/sweepProtocolFeesForToken(address,address,uint256,uint256,address) | 0xcc58c158f60f8590f5c29f5d8011ea04dc0f5c99d5570323f9d01cbd10cccbea | BIP-797 |    1     |
| Authorizer/grantRoles | multisigs/maxi_omni                                 | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/cancelOrder(address,address)                                          | 0xc8db914c03d0b22fd88d4a6a7d6310adb91800fddef8f47df1bef97a2a51e884 | BIP-797 |    2     |
|                       |                                                     |                                            | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/emergencyCancelOrder(address,address)                                 | 0x606b293b8ac13609d7e3d6a75f8261690f6628069a236692e32677dd03098cb8 |         |          |
|                       |                                                     |                                            | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/retryOrder(address,uint256,uint256)                                   | 0xa93c3f660f6c3f2fc8963c7bc7850c3572349b1ecc6c3dcd8fdd1bcc69b56f07 |         |          |
+-----------------------+-----------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W13/BIP-797-Wire-Up-V3-Protocol-Fee-ethereum.json
MULTISIG: multisigs/dao (mainnet:0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f)
COMMIT: 6b502d3271d02dce69738920bd9826248ff37274
CHAIN(S): mainnet
TENDERLY: 🟩 SUCCESS

+-----------------------+-----------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name                                         | caller_address                             | fx_paths                                                                                                               | action_ids                                                         |   bip   | tx_index |
+-----------------------+-----------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | 20250228-v3-protocol-fee-sweeper/ProtocolFeeSweeper | 0xd22eecBB495380Ef52b1CCeF1cA594979885D484 | 20250214-v3-protocol-fee-controller-v2/ProtocolFeeController/withdrawProtocolFeesForToken(address,address,address)     | 0x9fe8e7d354d4d4c9b828af97a9fb461b79747eb597d1d1919127b884ed03a3df | BIP-797 |    0     |
|                       |                                                     |                                            | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/burn(address,address,uint256,address,uint256,address,uint256)         | 0x9dee5e8e180c04cd338ca59779239cc78a0ef36e21890593ce1fe7ab0535af86 |         |          |
| Authorizer/grantRoles | EOA/keepers/v3_fee_bot                              | 0x74E283B985EA76c55C8B48d6bD1067a418188424 | 20250228-v3-protocol-fee-sweeper/ProtocolFeeSweeper/sweepProtocolFeesForToken(address,address,uint256,uint256,address) | 0x40ee140b57ea1dd1a1d08e4a35b764ed0e65dc70ddb51bcb4ac474358f6b213c | BIP-797 |    1     |
| Authorizer/grantRoles | multisigs/maxi_omni                                 | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/cancelOrder(address,address)                                          | 0x2962a8b0a821e0e122059f26693f7d6049214d298c12ff53016bc4f7246bda1b | BIP-797 |    2     |
|                       |                                                     |                                            | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/emergencyCancelOrder(address,address)                                 | 0x4e46bd7d6b5367df1ff5d4192d987dc8ac7efaaf8c876a427046a67871d8a18e |         |          |
|                       |                                                     |                                            | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/retryOrder(address,uint256,uint256)                                   | 0xb21f18865fc8d371e2cd65e0fc923f0469bfd9a106728f4466f5e3535fa0eeed |         |          |
+-----------------------+-----------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

FILENAME: BIPs/2025-W13/BIP-797-Wire-Up-V3-Protocol-Fee-gnosis.json
MULTISIG: multisigs/dao (gnosis:0x2a5AEcE0bb9EfFD7608213AE1745873385515c18)
COMMIT: 6b502d3271d02dce69738920bd9826248ff37274
CHAIN(S): gnosis
TENDERLY: 🟩 SUCCESS

+-----------------------+-----------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function              | caller_name                                         | caller_address                             | fx_paths                                                                                                               | action_ids                                                         |   bip   | tx_index |
+-----------------------+-----------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | 20250228-v3-protocol-fee-sweeper/ProtocolFeeSweeper | 0x1bcA39b01F451b0a05D7030e6e6981a73B716b1C | 20250214-v3-protocol-fee-controller-v2/ProtocolFeeController/withdrawProtocolFeesForToken(address,address,address)     | 0x7c0fa8c5add2fab51cc64b00dc8278f6829e8235e9ac804973fc336736b88ba6 | BIP-797 |    0     |
|                       |                                                     |                                            | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/burn(address,address,uint256,address,uint256,address,uint256)         | 0x550dbb0ba7b87f6c77a30b7559b4078dafbd6c35c257adc9bfa42c4a8042c0e8 |         |          |
| Authorizer/grantRoles | EOA/keepers/v3_fee_bot                              | 0x74E283B985EA76c55C8B48d6bD1067a418188424 | 20250228-v3-protocol-fee-sweeper/ProtocolFeeSweeper/sweepProtocolFeesForToken(address,address,uint256,uint256,address) | 0xa416691cb28def2fe33e6860b33636e69616f4ff9d71ff477f11499a30886356 | BIP-797 |    1     |
| Authorizer/grantRoles | multisigs/maxi_omni                                 | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/cancelOrder(address,address)                                          | 0x5a8ff4e96aec20c15090bab4dfb2044c26640b11397719826f3fae35af71f6fd | BIP-797 |    2     |
|                       |                                                     |                                            | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/emergencyCancelOrder(address,address)                                 | 0xc2a80baf0ed1f066df5b19750ecdcaf84afdfd8442e8eaf892b2db94c7455c78 |         |          |
|                       |                                                     |                                            | 20250221-v3-cow-swap-fee-burner/CowSwapFeeBurner/retryOrder(address,uint256,uint256)                                   | 0x9a8caba945fa103f13d5bc9ef3c72c37f4a107088b1b3cef27bdf55cd6cf6cf7 |         |          |
+-----------------------+-----------------------------------------------------+--------------------------------------------+------------------------------------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+

@gosuto-inzasheru gosuto-inzasheru marked this pull request as draft March 11, 2025 09:05
@gosuto-inzasheru gosuto-inzasheru changed the title [BIP-XXX] Wire Up V3 Protocol Fee Processing Permissions [BIP-797] Wire Up V3 Protocol Fee Processing Permissions Mar 13, 2025
@gosuto-inzasheru gosuto-inzasheru marked this pull request as ready for review March 13, 2025 08:16
@gosuto-inzasheru gosuto-inzasheru requested a review from Xeonus March 13, 2025 08:16
Copy link
Collaborator

@Xeonus Xeonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • permissions match props in proposal
  • correct/identical permission set for each network
  • burner functions allow to withdraw to other target if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants