[models] change capacity in ball column name to ability #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note, all migrations are currently on hold until we get rid of tortoise |
laggron42
added
blocked
laggron42
reviewed
Feb 24, 2025
| capacity_logic = models.JSONField( | ||
| help_text="Effect of this capacity", blank=True, default=dict | ||
| ability_description = models.CharField( | ||
| max_length=256, help_text="Description of the countryball's ability", default=None |
There was a problem hiding this comment.
Why are you adding default=None to name and description? Columns aren't nullable so this will fail
There was a problem hiding this comment.
because otherwise django wouldn't generate the migration, should i make the fields not null?
There was a problem hiding this comment.
It's detected when I do it. Don't use the --no-input flag when making migrations, that would explain why they aren't detected.
Don't change anything other than the name of the column, other attributes should be left intact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming it, avoids confusion especially with new self hosters.
Tasks: